Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Squeezenet] Upgrade to burn 0.13.0 #33

Merged
merged 2 commits into from
May 15, 2024

Conversation

CaptainVincent
Copy link
Contributor

  • Upgrade to burn 0.13.0
  • Add feature flag to disable copy the weights file
    This copy dest path functions properly only within the example.
    Currently, I cannot think of a better solution. So I just isolate this behavior for now to prevent projects using this crate will build fail when the weights_file feature is enabled.

@antimora antimora requested a review from laggui May 13, 2024 16:06
* Upgrade to burn 0.13.0
* Add feature flag to disable copy the weights file

Signed-off-by: vincent <[email protected]>
@CaptainVincent
Copy link
Contributor Author

Sorry about lint error, retry after cargo fmt.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we need to update the minimum Rust version to 1.75 for the CI to work properly. Thanks for the update!

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping the implementation up to date! 🎉

@CaptainVincent
Copy link
Contributor Author

Thanks for all your feedback. Adding a commit for updating the CI Rust version.

@laggui
Copy link
Member

laggui commented May 14, 2024

Thanks for fixing the CI 🙏

@laggui laggui merged commit e2f060f into tracel-ai:main May 15, 2024
2 checks passed
@CaptainVincent CaptainVincent deleted the upgrade-burn-version branch May 16, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants