Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug Report: pinecone-client package is giving error #2753

Open
1 task done
elinacse opened this issue Mar 6, 2025 · 2 comments · May be fixed by #2764
Open
1 task done

🐛 Bug Report: pinecone-client package is giving error #2753

elinacse opened this issue Mar 6, 2025 · 2 comments · May be fixed by #2764
Labels
bug Something isn't working

Comments

@elinacse
Copy link
Contributor

elinacse commented Mar 6, 2025

Which component is this bug for?

Pinecone Instrumentation

📜 Description

as per openllmetry pinecone-instrumentation the supported pinecone package is pinecone-client but seems it's replaces with pinecone hence giving error when trying to run pinecone with pinecone-client pkg installation .

👟 Reproduction steps

do pip install pinecone-client and try to run the pinecone sample . You will get error at runtime

Error -

Exception: The official Pinecone python package has been renamed from pinecone-client to pinecone. Please remove pinecone-client from your project dependencies and add pinecone instead. See the README at https://github.com/pinecone-io/pinecone-python-client for more information on using the python SDK.

👍 Expected behavior

we should install pinecone instead of pinecone-client and do the same change in openllmetry to support pinecone .

👎 Actual Behavior with Screenshots

python sample runs fine with installed pinecone package <6.0.0

🤖 Python Version

3.11.11

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!
@dosubot DosuBot
Copy link

dosubot bot commented Mar 6, 2025

To resolve the error caused by the package name change from pinecone-client to pinecone in the Pinecone Instrumentation for OpenLLmetry, you need to update the dependencies in the OpenLLmetry repository. Specifically, modify the PineconeInstrumentor class in the __init__.py file to use the new package name pinecone instead of pinecone-client. Update the _instruments tuple as follows:

_instruments = ("pinecone >= 2.2.2, <6",)

Additionally, ensure that the pyproject.toml file in the packages/opentelemetry-instrumentation-pinecone directory is updated to reflect this change. This will ensure that the correct package is referenced for instrumentation dependencies [1][2].

To continue talking to Dosu, mention @dosu.

Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@dosubot dosubot bot added the bug Something isn't working label Mar 6, 2025
@nirga
Copy link
Member

nirga commented Mar 8, 2025

Todos:

  1. Uninstall dosubot - it's been annoying for us for way too long.
  2. change the package version like you suggested :)

@nirga nirga linked a pull request Mar 8, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(pinecone): new package name traceloop/openllmetry
2 participants
@nirga @elinacse