-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pinecone): new package name #2764
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 6d74188 in 1 minute and 7 seconds
More details
- Looked at
33
lines of code in3
files - Skipped
2
files when reviewing. - Skipped posting
6
drafted comments based on config settings.
1. packages/opentelemetry-instrumentation-pinecone/.python-version:1
- Draft comment:
Bump to Python 3.12; confirm all dependencies support it. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is related to a dependency change, specifically bumping the Python version. It asks the PR author to confirm that all dependencies support the new version, which violates the rule against asking for confirmation or verification of dependency compatibility.
2. packages/opentelemetry-instrumentation-pinecone/pyproject.toml:46
- Draft comment:
Update dependency name to 'pinecone'; check extras consistency. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking to update a dependency name and check for extras consistency. This seems to be related to dependency management, which is not allowed according to the rules. The comment does not provide a specific code suggestion or ask for a test to be written, which would make it acceptable.
3. packages/sample-app/pyproject.toml:29
- Draft comment:
Rename pinecone dependency; ensure sample-app compatibility with version ^6.0.1. - Reason this comment was not posted:
Comment looked like it was already resolved.
4. packages/opentelemetry-instrumentation-pinecone/.python-version:1
- Draft comment:
Bumped Python version to 3.12. Ensure all deps and tests are compatible. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to ensure compatibility of dependencies and tests with the new Python version. This violates the rule against asking the author to ensure things are tested or compatible.
5. packages/sample-app/pyproject.toml:29
- Draft comment:
Updated dependency to 'pinecone' (^6.0.1). Verify new version is backward compatible with previous usage. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify backward compatibility of a dependency update, which falls under the rule of not asking the author to ensure compatibility or verify behavior. This is not a specific code suggestion or a request for a test, so it should be removed.
6. packages/opentelemetry-instrumentation-pinecone/pyproject.toml:53
- Draft comment:
It appears that in the [tool.poetry.extras] section (line 53), the instruments list still references "pinecone-client" even though the dependency has been updated to "pinecone" (line 46). Please confirm if this is intentional or if it should be updated for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_vvsxH7LqoJ1MTfxt
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -43,7 +43,7 @@ vcrpy = "^6.0.1" | |||
pytest-recording = "^0.13.1" | |||
opentelemetry-sdk = "^1.27.0" | |||
opentelemetry-instrumentation-openai = { path = "../opentelemetry-instrumentation-openai", develop = true } | |||
pinecone-client = "^5.0.0" | |||
pinecone = "^6.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed dep from pinecone-client
to pinecone
. Confirm extras/plugins (line 53 & 56) align with new naming.
Fixes #2753
feat(instrumentation): ...
orfix(instrumentation): ...
.