86b1u0zh6: I have completed Email integration using Gmail #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsaranga
suggested changes
Aug 27, 2024
Contributor
bsaranga
left a comment
bsaranga
left a comment
There was a problem hiding this comment.
Don't commit node_modules make sure it's ignored via .gitignore
bsaranga
suggested changes
Aug 29, 2024
server/src/middleware.ts
Outdated
| if (!cookie || cookie.value != 'authenticated') { | ||
| return NextResponse.redirect(`${process.env.BASE_URL}/login`); | ||
| } | ||
| // let cookie = request.cookies.get("token"); |
Contributor
There was a problem hiding this comment.
let's not comment these, we will wait for completed authentication middleware and use it here.
bsaranga
suggested changes
Aug 31, 2024
Contributor
bsaranga
left a comment
bsaranga
left a comment
There was a problem hiding this comment.
Attend to the changes requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
86b1u0zh6: I have completed Email integration using Gmail