86b1tvmtu #29
Open
86b1tvmtu #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… web responsiveness, use client components inside server components
bsaranga
suggested changes
Aug 30, 2024
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "liveServer.settings.port": 5501 | |||
Contributor
There was a problem hiding this comment.
Remove this. Use nextjs development server.
server/package.json
Outdated
| "@radix-ui/react-slot": "^1.1.0", | ||
| "@shadcn/ui": "^0.0.4", | ||
| "antd": "^5.20.2", | ||
| "antd": "^5.20.3", |
Contributor
There was a problem hiding this comment.
Ant design shouldn't be installed. Make sure you took a pull from development.
Contributor
Author
There was a problem hiding this comment.
yes, pull from development
server/src/app/index.css
Outdated
| @apply bg-background text-foreground; | ||
| } | ||
| } | ||
| /* Custom styles for the layout */ |
Contributor
There was a problem hiding this comment.
Remove all of these and use tailwindcss classes.
Contributor
Author
|
i made the changes, please review code |
Contributor
|
@s92068606 fix merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
86b1tvmtu: i have created reset password UI design