fix: patch SRI vulnerability detected by SecurityScorecard #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpsoraggi
requested review from
Copilot and
mloiseleur
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a security vulnerability by adding Subresource Integrity (SRI) protection to an external JavaScript file. The change adds integrity and crossorigin attributes to a script tag loading from traefik.github.io to ensure the script hasn't been tampered with.
- Adds SRI hash verification for the traefiklabs-header-app script
- Includes crossorigin attribute to enable SRI validation for cross-origin resources
|
Closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. https://github.com/traefik/infra/issues/8953
It also flags google fonts, but SRI is not supported
Hash generated here or by running:
Hash will be updated with every publish, see this PR