Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign method name as :id if the task is a method object #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Assign method name as :id if the task is a method object #12

wants to merge 2 commits into from

Conversation

yogeshjain999
Copy link
Member

No description provided.

@yogeshjain999 yogeshjain999 force-pushed the improvement/automatic_id branch from 74e1b19 to f71cc48 Compare January 14, 2020 08:28
@apotonick
Copy link
Member

We (you!!!) should check if this is still needed in 1.0. 🍻

@yogeshjain999
Copy link
Member Author

Oh wow, my 1st PR and I forgot it 😄

Sure, will do ❤️

@yogeshjain999
Copy link
Member Author

I'm thinking that we shouldn't do :id conversion and keep it as is i.e. method() object . It gives more info about step in trace and distinguishes itself. wdyt ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogeshjain999 @apotonick