Add #![feature(rustc_private)] to driver's main.rs#1298
Merged
Conversation
Recently, this seems to have become necessary to build drivers on macOS.
Collaborator
Author
|
TODO: Find the specific commit that made this PR necessary. |
Collaborator
Author
|
On macOS, the dylint/dylint/src/driver_builder.rs Line 235 in ba0b0ea But the test passes when the line is changed to nightly-2024-08-11 (commit 730d5d409).
So the relevant commit is somewhere between Here is the list of all such commits: |
Collaborator
Author
|
This appears to be the relevant PR, though I don't know which commit specifically: rust-lang/rust#122362 |
hlisdero
added a commit
to hlisdero/cargo-check-deadlock
that referenced
this pull request
Aug 30, 2024
Now we need `#![feature(rustc_private)]` in the `main.rs` See the original PR rust-lang/rust#122362 And the PR in another tool that requires the same change trailofbits/dylint#1298 Update lock file too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, this seems to have become necessary to build drivers on macOS.