Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core symbol tables #660

Merged
merged 60 commits into from
Aug 28, 2024
Merged

Core symbol tables #660

merged 60 commits into from
Aug 28, 2024

Conversation

xlauko
Copy link
Member

@xlauko xlauko commented Jul 10, 2024

No description provided.

@xlauko xlauko added the mlir label Jul 10, 2024
@xlauko xlauko self-assigned this Jul 10, 2024
@xlauko xlauko force-pushed the core-symbol-tables branch 3 times, most recently from 8398cc7 to 9d5596c Compare July 30, 2024 13:15
@xlauko xlauko force-pushed the core-symbol-tables branch 2 times, most recently from c085727 to 2667ee0 Compare August 7, 2024 13:53
@xlauko xlauko marked this pull request as ready for review August 14, 2024 10:06
@frabert frabert force-pushed the core-symbol-tables branch 4 times, most recently from 35095e4 to f822a19 Compare August 14, 2024 13:27
@xlauko xlauko requested review from frabert and Jezurko August 26, 2024 09:21
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 32 file(s) not formatted
  • include/vast/ABI/MLIRTypeInfo.hpp
  • include/vast/CodeGen/CodeGenDriver.hpp
  • include/vast/Conversion/Common/Patterns.hpp
  • include/vast/Dialect/Core/CoreOps.hpp
  • include/vast/Dialect/Core/SymbolTable.hpp
  • include/vast/Interfaces/SymbolInterface.hpp
  • include/vast/Interfaces/SymbolRefInterface.hpp
  • include/vast/Interfaces/SymbolTableInterface.hpp
  • include/vast/Target/LLVMIR/Convert.hpp
  • include/vast/Util/Common.hpp
  • include/vast/Util/Pipeline.hpp
  • lib/vast/CodeGen/CodeGenDriver.cpp
  • lib/vast/CodeGen/DataLayout.cpp
  • lib/vast/Conversion/ABI/EmitABI.cpp
  • lib/vast/Conversion/Core/Passes.cpp
  • lib/vast/Conversion/ToLLVM/IRsToLLVM.cpp
  • lib/vast/Dialect/Core/CoreOps.cpp
  • lib/vast/Dialect/Core/SymbolTable.cpp
  • lib/vast/Dialect/HighLevel/HighLevelTypes.cpp
  • lib/vast/Dialect/HighLevel/HighLevelVar.cpp
  • lib/vast/Dialect/HighLevel/Transforms/LowerEnums.cpp
  • lib/vast/Dialect/LowLevel/Transforms/ToLLVM.cpp
  • lib/vast/Frontend/Action.cpp
  • lib/vast/Frontend/Consumer.cpp
  • lib/vast/Interfaces/SymbolRefInterface.cpp
  • lib/vast/Interfaces/SymbolTableInterface.cpp
  • lib/vast/Target/LLVMIR/Convert.cpp
  • lib/vast/Util/Pipeline.cpp
  • tools/vast-query/vast-query.cpp
  • tools/vast-repl/codegen.cpp
  • tools/vast-repl/command.cpp
  • tools/vast-repl/state.cpp
clang-tidy reports: 23 concern(s)
  • include/vast/Conversion/ABI/AggregateTypes.hpp:44:45: error: [clang-diagnostic-error]

    unknown type name 'mlir_type'

       44 |             std::size_t align_paddding_size(mlir_type type) {
          |                                             ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:53:16: error: [clang-diagnostic-error]

    unknown type name 'mlir_type'

       53 |         static mlir_type mk_int_type(mcontext_t &mctx, auto size) {
          |                ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:53:38: error: [clang-diagnostic-error]

    unknown type name 'mcontext_t'

       53 |         static mlir_type mk_int_type(mcontext_t &mctx, auto size) {
          |                                      ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:62:28: error: [clang-diagnostic-error]

    unknown type name 'mlir_type'

       62 |         bool needs_nesting(mlir_type type) const {
          |                            ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:67:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

       67 |         gap::generator< mlir_value > field_ptrs(
          |         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:67:25: error: [clang-diagnostic-error]

    use of undeclared identifier 'mlir_value'

       67 |         gap::generator< mlir_value > field_ptrs(
          |                         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:68:13: error: [clang-diagnostic-error]

    use of undeclared identifier 'hl'

       68 |             hl::ArrayType array_type, mlir_value value,
          |             ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:68:39: error: [clang-diagnostic-error]

    unknown type name 'mlir_value'

       68 |             hl::ArrayType array_type, mlir_value value,
          |                                       ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:83:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

       83 |         gap::generator< mlir_value > field_ptrs(
          |         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:83:25: error: [clang-diagnostic-error]

    use of undeclared identifier 'mlir_value'

       83 |         gap::generator< mlir_value > field_ptrs(
          |                         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:84:13: error: [clang-diagnostic-error]

    use of undeclared identifier 'hl'

       84 |             hl::RecordType record_type, mlir_value value,
          |             ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:84:41: error: [clang-diagnostic-error]

    unknown type name 'mlir_value'

       84 |             hl::RecordType record_type, mlir_value value,
          |                                         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:103:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      103 |         gap::generator< mlir_value > field_ptrs(operation root, auto loc, auto &bld) const {
          |         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:103:25: error: [clang-diagnostic-error]

    use of undeclared identifier 'mlir_value'

      103 |         gap::generator< mlir_value > field_ptrs(operation root, auto loc, auto &bld) const {
          |                         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:103:49: error: [clang-diagnostic-error]

    unknown type name 'operation'

      103 |         gap::generator< mlir_value > field_ptrs(operation root, auto loc, auto &bld) const {
          |                                                 ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:122:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      122 |         gap::generator< mlir_type > fields(hl::ArrayType array_type) const {
          |         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:122:25: error: [clang-diagnostic-error]

    use of undeclared identifier 'mlir_type'

      122 |         gap::generator< mlir_type > fields(hl::ArrayType array_type) const {
          |                         ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:122:44: error: [clang-diagnostic-error]

    use of undeclared identifier 'hl'

      122 |         gap::generator< mlir_type > fields(hl::ArrayType array_type) const {
          |                                            ^
  • include/vast/Conversion/ABI/AggregateTypes.hpp:131:21: error: [clang-diagnostic-error]

    unknown type name 'mlir_type'

      131 |         auto fields(mlir_type t, core::module mod) const {
          |                     ^
  • include/vast/Conversion/TypeConverters/LLVMTypeConverter.hpp:5:1: error: [clang-diagnostic-error]

    unknown type name 'VAST_RELAX_WARNINGS'

        5 | VAST_RELAX_WARNINGS
          | ^
  • include/vast/Conversion/TypeConverters/LLVMTypeConverter.hpp:15:1: error: [clang-diagnostic-error]

    unknown type name 'VAST_UNRELAX_WARNINGS'

       15 | VAST_UNRELAX_WARNINGS
          | ^
  • include/vast/Interfaces/SymbolInterface.hpp:25:10: error: [clang-diagnostic-error]

    'vast/Interfaces/SymbolInterface.h.inc' file not found

       25 | #include "vast/Interfaces/SymbolInterface.h.inc"
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  • include/vast/Interfaces/SymbolRefInterface.hpp:16:10: error: [clang-diagnostic-error]

    'vast/Interfaces/SymbolRefInterface.h.inc' file not found

       16 | #include "vast/Interfaces/SymbolRefInterface.h.inc"
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit f178764 into master Aug 28, 2024
8 checks passed
@xlauko xlauko deleted the core-symbol-tables branch August 28, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants