Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compilation on macOS more clear #1115

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Make compilation on macOS more clear #1115

wants to merge 5 commits into from

Conversation

Metal-Snake
Copy link

I added information on how to compile on mac in the readme.md, also I removed the scripts setup/macosx/create_app.sh and create_package.sh and renamed create_app_new.sh to create_app.sh

If those scripts are still needed let me now what those are for (they didn't work on my machine) and I will update accordingly.

PeterDaveHello
PeterDaveHello requested changes Apr 7, 2018
View reviewed changes
Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash e36eada into 45a5961, they should not be separated.

Instead of adding the notes about fpc and lazarus can't work from Homebrew, I personally more prefer to solve the issue in fact.

README.md Outdated

### macOS

**Note: Currently Transmission Remote GUI can't be compiled if fpc and lazarus were installed using brew. You can uninstall them using** `brew uninstall fpc` and `brew cask uninstall lazarus`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brew should be Homebrew

README.md Outdated

**Note: Currently Transmission Remote GUI can't be compiled if fpc and lazarus were installed using brew. You can uninstall them using** `brew uninstall fpc` and `brew cask uninstall lazarus`

In Terminal navigate to the transgui folder containing the source code. Then `cd setup/macosx` and run `./create_app.sh`. This will install fpc and lazarus if needed and build Transmission Remote GUI and move it in a .dmg image file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This instruction should be more precise and separate the step to prepare environment and to compile.

@Metal-Snake
Copy link
Author

I updated the ReadMe.md
Is this ok now?

I agree, fixing the build using brew's fpc/lazarus should be done. That's why I wrote Currently it can't be done with those.
But that means checking what's going on, compare both installs. I would do this using VirtualMachines and compare those. But my current machine is too weak, I hope for a new iMac this year, if that gets released I buy one and then I will look into it. For the time being it's better to explain it than to be silent about it.

How would I squash 2 commits together?

@PeterDaveHello
Copy link
Member

@Diskutant yeah I agree to have that message right now, will take a look soon, thanks.

@PeterDaveHello PeterDaveHello force-pushed the master branch 3 times, most recently from edddb71 to be92509 Compare May 1, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterDaveHello PeterDaveHello PeterDaveHello requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Metal-Snake @PeterDaveHello