-
Notifications
You must be signed in to change notification settings - Fork 0
Fix Gradle deprecation warnings in build configuration #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: trask <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot is isVisible
even needed? can we just remove it?
Co-authored-by: trask <[email protected]>
You're absolutely right! The I've removed all Fixed in commit aab872c. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
f22b5fc
to
8a4d66b
Compare
This PR resolves several Gradle deprecation warnings that appeared when running
./gradlew assemble
with--warning-mode=all
. The warnings were related to deprecated Kotlin/Gradle APIs that will be removed in future versions.Fixed Warnings
1. Deprecated Task Creation API
Fixed in
OtelVersionClassPlugin.kt
:project.task(name, configureAction)
withproject.tasks.register(name, configureAction)
2. Deprecated Configuration.isVisible Property
Fixed in multiple build files:
isVisible = false
property usage instead of suppressing warnings:otel.jacoco-conventions.gradle.kts
(2 occurrences)otel.java-conventions.gradle.kts
(1 occurrence)all/build.gradle.kts
(2 occurrences)The
isVisible
property was only used to hide internal configurations from dependency reports and IDE views, but it's not functionally necessary. Removing it entirely eliminates the deprecation warnings while maintaining all functionality.Remaining Warnings
Two warnings remain that originate from the external
protobuf-gradle-plugin
(v0.9.5):Impact
The changes are minimal and focused only on resolving the deprecation warnings without altering build behavior.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.