netlink.erl: Fix is_rt_dump #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://kernel.org/doc/html/next/userspace-api/netlink/intro.html: """ For GET - NLM_F_ROOT and NLM_F_MATCH are combined into NLM_F_DUMP, and not used separately. NLM_F_ATOMIC is never used. """ This fixes nl_rt_dec() incorrectly entering the is_rt_dump() path when a response for create interface is received, because it has NLM_F_ROOT set but not NLM_F_MATCH, and hence before this patch it would make is_rtp_dump() incorrectly return true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kernel.org/doc/html/next/userspace-api/netlink/intro.html: """
For GET - NLM_F_ROOT and NLM_F_MATCH are combined into NLM_F_DUMP, and not used separately. NLM_F_ATOMIC is never used. """
This fixes nl_rt_dec() incorrectly entering the is_rt_dump() path when a response for create interface is received, because it has NLM_F_ROOT set but not NLM_F_MATCH, and hence before this patch it would make is_rtp_dump() incorrectly return true.