Use bit shifting instead of math:power #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like a good idea, but the patch I just merged conflicts - please update if you'd like to get this in |
|
I have merged the changes. Please review and pull. |
Since crypto:rand_uniform returns N, with Lo <= N < Hi, we don't need -1 here.
|
Sorry about that. I included those changes and removed the |
|
ok great. @robertoaloi @shoehn would you mind taking a look too? I'm far enough out from all of this that I'm not 100% sure this is right. if you don't get to it I'll test it sometime soon and get it merged. thanks for the patch @sluu99 ! |
|
shoot, haven't gotten to this yet and it looks like it's become unmergable in the mean time - could you update this PR to make it mergable? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.