Update Import/Workflow Endpoint Configurations #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, no... I'll fix the failing tests later (it's only about workflow) |
1 similar comment
tagomoris
force-pushed
the
update-configuration-classes
branch
from
d9a7de6 to
661f412
Compare
tagomoris
force-pushed
the
update-configuration-classes
branch
from
661f412 to
bc6c719
Compare
|
Added a change to fix CI failures. |
nurse
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have default values supposed from default endpoint value, and also to allow to override those endpoints via command-line options.
In order to realize those things, I added some internal classes. Because the former way to manage configuration values requires to add many class variables and methods (like
cl_*), and it is really messy & uncontrollable.So, this change is a little larger than I expected. I want to hear the reviewers' comments.