Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Prefix To all Leap Atom Classes #24

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Adding Prefix To all Leap Atom Classes #24

wants to merge 27 commits into from

Conversation

thinmatt
Copy link
Contributor

@thinmatt thinmatt commented Sep 1, 2017 •
edited
Loading

In an effort to make the Leap name scheme more unique and provide the ability to more easily drop leap into an existing application without conflicts, I am adding a prefix to all leap classes. The prefix will have a variable so it can be easily adjusted if need be. Defaulting to .thl for now which stands for Treehouse Leap.

Atom To Dos:

  • Block Grid
  • Border
  • Buttons
  • Colors
  • Display
  • Flexbox
  • Float
  • Forms
  • Grid
  • Icon
  • Margin
  • Overflow
  • Padding
  • Position
  • Rotation
  • Table
  • Type
  • Vertical Alignment
  • Widht & Height

General To Dos:

  • Audit style guide pages for proper use of classes with prefix
    • Index
    • Getting Started
    • Sass
    • Responsive
    • Atoms Pages
    • Release Notes
  • Check in on Icon Helper/Name scheme to determine if we should prefix

@thinmatt
updating block grid to work with leap prefix
87571d3
@thinmatt
adding in prefix for border elements
976b977
@thinmatt
continuing to replace border classes with prefix
30d4a7e
@thinmatt
combing through the rest of the styleguide to update border to use pr…
cc60c77 
…efix
@thinmatt
updating uses for button class around styleguide pages
5d99502
@thinmatt
adding in prefix for colors
be0a8d3
@thinmatt
adding in prefixes for display and grabbing a few border classes as w…
4eed323 
…ell that I missed
@thinmatt
updating flex classes on flexbox page
e6af098
@thinmatt
updating reponsive example with flex
6f7385e
@thinmatt
prefixing for float classes
f0f863b
@thinmatt
fixing missing block prefix in color js
5f84886
@thinmatt
replacing more float classes
720822e
@thinmatt
updating form classes with prefix and compiling the updated CSS files
6712831
@thinmatt
fixing syntax error where I double prefixed form styles
e46de5d
@thinmatt
adding in more prefixing for advanced selectors
dec3e4d
@thinmatt
adding in grid prefixes
9fd24b7
@thinmatt
adding in border prefix for release notes
3f69e93
@thinmatt
updating leap icon classes
ff359b7
@thinmatt
adding in margin prefix to sass and layout file
c8cc5b9
@thinmatt
adding in margin prefixes to style guide layouts
a81ccf7
@thinmatt
updating grid layout with block prefix
da706b9
@thinmatt
Adding in more margin prefixes
99a8d92
@thinmatt
adding in more margin prefixes
8009d9b
@thinmatt
adding in updated css files
48a50e4
@thinmatt
catching last of the margin prefixes
4b4e43a
@thinmatt
cleaning out a rogue prefix inside a class name
8b8336c
@thinmatt
adding in overflow prefixes
457efe2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinmatt