Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: minor fixes to lakeFS quickstart #6990

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Docs: minor fixes to lakeFS quickstart #6990

merged 3 commits into from
Nov 14, 2023

Conversation

talSofer
Copy link
Contributor

Change Description

Minor fixes in the lakeFS quickstart manual.

How was this tested

Before this change, the hook formatting was invalid and failed the lakeFS commit. I uploaded the hook in its new formatting as it shows in the docs, and committed to lakeFS successfully.

@talSofer talSofer added the minor-change Used for PRs that don't require issue attached label Nov 14, 2023
@talSofer talSofer requested a review from ozkatz November 14, 2023 11:48
Copy link

github-actions bot commented Nov 14, 2023

♻️ PR Preview fc4b43a has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@talSofer talSofer added the exclude-changelog PR description should not be included in next release changelog label Nov 14, 2023
end
end
```
1. Open up your favorite text editor (or emacs), and paste the following YAML:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turns it into step 1.a. instead of 2. - is that what we want?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, good catch I fixed it

@talSofer talSofer requested a review from ozkatz November 14, 2023 12:14
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for catching and fixing!

@talSofer talSofer merged commit 5d21ec4 into master Nov 14, 2023
31 checks passed
@talSofer talSofer deleted the quickstart-fixes branch November 14, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants