Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty metadata in import #7364

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Handle empty metadata in import #7364

merged 2 commits into from
Feb 2, 2024

Conversation

itaiad200
Copy link
Contributor

closes #7363

@itaiad200 itaiad200 added the include-changelog PR description should be included in next release changelog label Feb 2, 2024
@itaiad200 itaiad200 requested a review from N-o-Z February 2, 2024 10:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

10 passed

arielshaqed
arielshaqed approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itaiad200 itaiad200 enabled auto-merge (squash) February 2, 2024 14:10
@itaiad200 itaiad200 merged commit e9478e5 into master Feb 2, 2024
@itaiad200 itaiad200 deleted the 7363-empty-metadata-import-panic branch February 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z left review comments

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: LakeFs Import kills LakeFS instances if CommitCreation has empty metadata
3 participants
@itaiad200 @N-o-Z @arielshaqed