Bump OpenAPI codegen #8101
Draft
Bump OpenAPI codegen #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also stops using the Treeverse fork; AFAICT that changes some documentation formatting. So of course we must ensure that we are happy with the generated code.
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
N-o-Z
reviewed
Aug 26, 2024
There was a problem hiding this comment.
The reason we did not update generator image is because it introduces breaking changes to our SDKs.
One example for that is in the Python SDK, where the async_req flag has been removed from the client.
There are also several changes in data types which might be break user envs.
BTW did they solve the upload issue for the RUST generator in the new version?
If that's the case it might be worth to just upgrade the generator images for RUST only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Please pay special attention to possible backwards-compatibility guarantees, especially in the Python client. This will be a minor version bump. So a summary of relevant points from our API guarantees for this bump:
(Only applies to APIs not marked "internal" or "experimental", but that should not make a difference here!)
Good bughunting!
This is only a draft to see whether we can do this.