Fix: Git package error handling #8345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
bug
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
arielshaqed
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
This is of course cool, but also unpleasant. E.g. this code still breaks because
❯ LANGUAGE=sv git status
På grenen docs/getting-started-on-the-project
inget att checka in, arbetskatalogen renwill happen in some places in Northern Europe.
Perhaps open an issue to discover a proper way to run Git plumbing?
| case strings.Contains(lowerOut, "remote not found"): | ||
| return "", errors.ErrRemoteNotFound | ||
| default: | ||
| return "", fmt.Errorf("%s: %w", out, err) |
There was a problem hiding this comment.
Odd: This error has a different format, it includes out.
There was a problem hiding this comment.
This is the only place where the output has any relevance
Opened #8348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8086
Change Description
Background
Parsing git shell commands response to classify into comprehensible errors, seems like some FS return different strings for the same errors.
Bug Fix
The bug resulted from difference in output when not a git repository
The fix was to lowercase the out put before comparison
Testing Details
Added unit test
Breaking Change?
No