Serverless application repository template #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AWS Security hub permission need to be added |
|
Security hub permission is added but testing is pending |
carpusherw
suggested changes
May 31, 2021
Comment on lines
+12
to
+26
| ## Deployment steps | ||
| 1. Visit plugin from serverless application repository | ||
|
|
||
| 2. Enter AWS Account details and AWS Security hub ARN | ||
| AWSACCOUNTNO: Provide your aws account ID | ||
| AWSSecurityHubARN: arn:aws:securityhub:<region>:<aws acc no>:product/<aws acc no>/default | ||
|
|
||
|
|
||
| 3. Copy ScanResultTopicArn from scanner cloudformation stack output. This is the same ARN that we have used in previous step for Quarantine and promote object. | ||
|
|
||
|
|
||
| 4. Enter ScanResultTopicARN to serverless application parameter and proceed to Deploy | ||
|
|
||
|
|
||
| 5. Verify serverless plugin deployment is completed. |
There was a problem hiding this comment.
Would you reference the doc from other exiting templates? Like, https://github.com/trendmicro/cloudone-filestorage-plugins/tree/master/post-scan-actions/aws-python-promote-or-quarantine#prerequisites
| C1FSecurityHub: | ||
| Type: AWS::Serverless::Function | ||
| Properties: | ||
| CodeUri: s3://bucket-4716/lambda.zip |
There was a problem hiding this comment.
I don't think it's a good idea to add a new template and new code from unmanaged bucket. Instead, modify the template.yaml would with a Metadata section like this would make more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Change Summary
PR Checklist
Other Notes