-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature validate spec #1188
base: master
Are you sure you want to change the base?
Feature validate spec #1188
Conversation
So I think a good goal here would be to get SSR validating fully. What that'll mean is that on pipeline save the owner fields need to be filled out to a minimum, this might just mean checking if the obj exists rather than the entire semantic fulfillment, and on mapping which will mean member fields have also been filled out to the same standard |
This validates on the input spec when it comes from the UI when saving a pipeline. Is the validation that happens here identical to what should happen when uploading a spec in simulator? is inputMap in the same form here as in other places? Aside from the UI, where should the validator be used? |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds validation to inputMap when saving a pipeline.
What is the current behavior? (You can also link to an open issue here)
closes _issue #_1184
What is the new behavior (if this is a feature change)?
Adds validation to inputMap when saving a pipeline.