Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature validate spec #1188

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Feature validate spec #1188

wants to merge 11 commits into from

Conversation

dylanmartin
Copy link
Collaborator

@dylanmartin dylanmartin commented Feb 4, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Tests for the changes have been added (for bug fixes / features)
  • Passes e2e testing
  • Passes lint
  • Docs have been added / updated if necessary (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Adds validation to inputMap when saving a pipeline.

  • What is the current behavior? (You can also link to an open issue here)
    closes _issue #_1184

  • What is the new behavior (if this is a feature change)?
    Adds validation to inputMap when saving a pipeline.

@dylanmartin dylanmartin requested a review from rssk March 24, 2022 14:26
@rssk
Copy link
Contributor

rssk commented Apr 19, 2022

So I think a good goal here would be to get SSR validating fully. What that'll mean is that on pipeline save the owner fields need to be filled out to a minimum, this might just mean checking if the obj exists rather than the entire semantic fulfillment, and on mapping which will mean member fields have also been filled out to the same standard

@dylanmartin
Copy link
Collaborator Author

This validates on the input spec when it comes from the UI when saving a pipeline. Is the validation that happens here identical to what should happen when uploading a spec in simulator? is inputMap in the same form here as in other places? Aside from the UI, where should the validator be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate spec on save pipeline Simulator: checks for specs using joi
2 participants