Update AutocompleteCore.js - Tab key also fires onSubmit #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I want to select a result with the keyboard when the autocomplete element appears in the context of a
<form>, pressing Enter to select it is undesirable, as the browser will try to submit the whole form; selecting from the list with Tab would be the idiomatic alternative, and this updates the input field as expected - but does not currently fire onSubmit as pressing Enter does, which means I can't as easily validate the selection/propagate the selected result. I have found that this small modification saves a lot of bother!