Add proxy support to search and scraper #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, is it possible to merge this branch? |
qalandarov
reviewed
Dec 20, 2023
| @@ -565,7 +566,7 @@ async def _paginate(self, client: AsyncClient, operation: tuple, **kwargs): | |||
| ids = set(find_key(initial_data, 'rest_id')) | |||
| cursor = get_cursor(initial_data) | |||
| except Exception as e: | |||
| self.logger.error('Failed to get initial pagination data', e) | |||
|
is it possible to merge this branch? |
User-23173
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hacky patch I mentioned in #97 couldn't get me all the way so I decided to fork. Hope I didn't miss anything while adding the proxy.