Improve error handling for invalid rss feeds

trevorsharp · Jan 6, 2025 · f6e0425 · f6e0425
1 parent b2c4522
commit f6e0425
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/bun.lockb b/bun.lockb
diff --git a/package.json b/package.json
@@ -25,7 +25,7 @@
     "react-hook-form": "^7.51.3",
     "server-only": "^0.0.1",
     "superjson": "^2.2.1",
-    "zod": "^3.22.4"
+    "zod": "^3.24.1"
   },
   "devDependencies": {
     "@types/eslint": "^8.56.2",

diff --git a/src/services/feedService.ts b/src/services/feedService.ts
@@ -45,7 +45,7 @@ const fetchFeedData = async (urls: string[], searchParams?: URLSearchParams) =>
         .then((response) => response.text())
         .then((data) => parseFeed(data))
         .catch((error) => {
-          console.log(error);
+          console.error(error);
           return undefined;
         });
     }),
@@ -59,9 +59,10 @@ const fetchFeedData = async (urls: string[], searchParams?: URLSearchParams) =>
   );
 };
 
-const parseFeed = (rawFeed: string): FeedData => {
+const parseFeed = (rawFeed: string): FeedData | undefined => {
   const parsedFeed = parser.parse(rawFeed) as unknown;
-  return feedSchema.parse(parsedFeed);
+  const { data: feedData, success } = feedSchema.safeParse(parsedFeed);
+  return success ? feedData : undefined;
 };
 
 const mergeFeeds = (mainFeed: FeedData, additionalFeeds: FeedData[]) => {