feat(suite-native): do not report FW revision offline error

trezor · Feb 6, 2025 · 41c1919 · 41c1919
1 parent dff99b4
commit 41c1919
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/suite-native/device/src/config/firmware.ts b/suite-native/device/src/config/firmware.ts
@@ -6,7 +6,7 @@ import { FirmwareRevisionCheckError } from '@trezor/connect';
  */
 
 // display a warning banner
-type SoftWarningBehavior = { type: 'softWarning'; shouldReport: true };
+type SoftWarningBehavior = { type: 'softWarning'; shouldReport: boolean };
 // display "Device Compromised" modal, after closing it dispaly a warning banner, block receiving address
 type HardModalBehavior = { type: 'hardModal'; shouldReport: true };
 
@@ -16,6 +16,6 @@ type RevisionCheckErrorScenarios = Record<FirmwareRevisionCheckError, RevisionEr
 export const revisionCheckErrorScenarios = {
     'revision-mismatch': { type: 'hardModal', shouldReport: true },
     'firmware-version-unknown': { type: 'hardModal', shouldReport: true },
-    'cannot-perform-check-offline': { type: 'softWarning', shouldReport: true },
+    'cannot-perform-check-offline': { type: 'softWarning', shouldReport: false },
     'other-error': { type: 'softWarning', shouldReport: true },
 } satisfies RevisionCheckErrorScenarios;
diff --git a/suite-native/device/src/hooks/useReportDeviceCompromised.ts b/suite-native/device/src/hooks/useReportDeviceCompromised.ts
@@ -6,6 +6,7 @@ import * as Sentry from '@sentry/react-native';
 import { selectSelectedDevice } from '@suite-common/wallet-core';
 import { getFirmwareVersion } from '@trezor/device-utils';
 
+import { revisionCheckErrorScenarios } from '../config/firmware';
 import { selectFirmwareRevisionCheckError } from '../selectors';
 
 const reportCheckFail = (checkType: 'Firmware revision', contextData: any) => {
@@ -31,7 +32,10 @@ export const useReportDeviceCompromised = () => {
     const revisionCheckError = useSelector(selectFirmwareRevisionCheckError);
 
     useEffect(() => {
-        if (revisionCheckError !== null) {
+        if (
+            revisionCheckError !== null &&
+            revisionCheckErrorScenarios[revisionCheckError].shouldReport
+        ) {
             reportCheckFail('Firmware revision', { ...commonData, revisionCheckError });
         }
     }, [commonData, revisionCheckError]);