-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(suite): unreadable device tips improvements #14637
Conversation
I would not lead them to KB article as there is a significant chance they will brick the device. I would just lead them directly to write tech support |
Regarding the button switch, @Hannsek and @Hermez-cz shall decide. I would be personakls up for adding it there. |
If we can target the specific firmwares then yes, let's do it. I had it in the design suggestion somewhere. But if it is just ~ 10 users, we shouldn't spend time on this. |
9f73375
to
529686a
Compare
I would do something like this (for desktop) ![]() and this for web ![]() explanation why I believe it makes sense as suggested here https://github.com/trezor/trezor-suite/pull/14637/files#diff-4f4ba83e95f4c0800b23ced0ac2643abf14ea387d3de6e91d0ac38b47113e2bfR123 cc @Hannsek please check on it and please give me the KB link. Also connect-device troubleshooting probably should be revisited as well. |
3f68846
to
c2cdc92
Compare
It seems fine to me. The KB article is here. @Hermez-cz please check it as well. |
Hi, I didn't catch if we can recognize affected devices. Is that possible please? The bridge toggle might be puzzling minds of all users with connection issues and there's no way they'll understand what it's about. They have no idea what bridge is, what might be an alternative implementation, what does the 3.0.0-bundled.24.10.0 mean etc. All feels very non-transparent and anyone might just feel forced to give it a blind shot. Also old Trezor model vs. firmware version sounds fuzzy like this. Should we refer only to firmware / device software perhaps? Because it doesn't mean a thing if my Model One would be very old if I'd keep it up to date. The URLs are the most prominent thing in the whole page, more prominent than those bullet point titles, is that intentional? |
Please do some adjustments:
|
c2cdc92
to
0b57c1c
Compare
f180348
to
b038222
Compare
…opApi hook to make it reusable
b038222
to
51dacde
Compare
export const Transport = () => ( | ||
// No transport layer (bridge/webUSB) is available | ||
// On web it makes sense to | ||
// - offer downloading Trezor Suite desktop, or | ||
// - use a browser that supports WebUSB | ||
// Desktop app should have Bridge transport layer available as it is built-in, if it is not available we fucked up something. | ||
<TroubleshootingTips | ||
label={<Translation id="TR_TROUBLESHOOTING_DEVICE_NOT_DETECTED" />} | ||
items={[ | ||
TROUBLESHOOTING_TIP_WEBUSB_ENVIRONMENT, | ||
TROUBLESHOOTING_TIP_SUITE_DESKTOP, | ||
TROUBLESHOOTING_TIP_RESTART_COMPUTER, | ||
]} | ||
data-testid="@connect-device-prompt/bridge-not-running" | ||
/> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no changes here. sorry for diff
51dacde
to
9113a35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Only thing I noticed when testing is when toggling bridge implementations the error changes into "App can't communicate with device" momentarily. But that's probably not important
@evgenysl Once you'll be testing that, please post here screenshots of how does it look now. 🙏🏻 |
This is what i see on 24.11.2 when i connect Info:
|
This is Node bridge and app with same device ![]() Info:
|
Hmm I think it should have displayed something different. Could you please also post old bridge status page with that device? |
addressing #14284
todos:
cc @MiroslavProchazka
resolve #14284