Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(suite): unreadable device tips improvements #14637

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Oct 1, 2024

addressing #14284

todos:

  • do we have a knowledge base article addressing old hid devices fw update issues?
  • do we wan't to include button to switch to using old bridge (desktop only)
image

cc @MiroslavProchazka

resolve #14284

@MiroslavProchazka
Copy link
Contributor

I would not lead them to KB article as there is a significant chance they will brick the device. I would just lead them directly to write tech support

@MiroslavProchazka
Copy link
Contributor

Regarding the button switch, @Hannsek and @Hermez-cz shall decide. I would be personakls up for adding it there.

@Hannsek
Copy link
Contributor

Hannsek commented Oct 1, 2024

If we can target the specific firmwares then yes, let's do it. I had it in the design suggestion somewhere.

But if it is just ~ 10 users, we shouldn't spend time on this.

@Hannsek
Copy link
Contributor

Hannsek commented Oct 1, 2024

We have this on KB:

image

@mroz22 mroz22 force-pushed the unreadeble-troubleshooting branch from 9f73375 to 529686a Compare October 1, 2024 15:55
@mroz22
Copy link
Contributor Author

mroz22 commented Oct 1, 2024

I would do something like this (for desktop)

image

and this for web

image

explanation why I believe it makes sense as suggested here https://github.com/trezor/trezor-suite/pull/14637/files#diff-4f4ba83e95f4c0800b23ced0ac2643abf14ea387d3de6e91d0ac38b47113e2bfR123

cc @Hannsek please check on it and please give me the KB link.

Also connect-device troubleshooting probably should be revisited as well.

@mroz22 mroz22 force-pushed the unreadeble-troubleshooting branch 4 times, most recently from 3f68846 to c2cdc92 Compare October 2, 2024 07:07
@Hannsek
Copy link
Contributor

Hannsek commented Oct 3, 2024

It seems fine to me. The KB article is here.

@Hermez-cz please check it as well.

@Hermez-cz
Copy link

Hi, I didn't catch if we can recognize affected devices. Is that possible please?

The bridge toggle might be puzzling minds of all users with connection issues and there's no way they'll understand what it's about. They have no idea what bridge is, what might be an alternative implementation, what does the 3.0.0-bundled.24.10.0 mean etc. All feels very non-transparent and anyone might just feel forced to give it a blind shot.

Also old Trezor model vs. firmware version sounds fuzzy like this. Should we refer only to firmware / device software perhaps? Because it doesn't mean a thing if my Model One would be very old if I'd keep it up to date.

The URLs are the most prominent thing in the whole page, more prominent than those bullet point titles, is that intentional?

@Hannsek
Copy link
Contributor

Hannsek commented Oct 8, 2024

Please do some adjustments:

  • display this 4 points error only for HID devices
  • other devices should see only first and fourth point (is there another troubleshooting step that may help core devices?)
  • adjust second point so that after clicking on the link, a bridge modal would appear where the toggle to switch to old bridge will be present

@mroz22 mroz22 force-pushed the unreadeble-troubleshooting branch from c2cdc92 to 0b57c1c Compare October 9, 2024 05:10
@mroz22 mroz22 force-pushed the unreadeble-troubleshooting branch 3 times, most recently from f180348 to b038222 Compare October 30, 2024 07:28
@mroz22 mroz22 force-pushed the unreadeble-troubleshooting branch from b038222 to 51dacde Compare October 30, 2024 09:43
Comment on lines -8 to -23
export const Transport = () => (
// No transport layer (bridge/webUSB) is available
// On web it makes sense to
// - offer downloading Trezor Suite desktop, or
// - use a browser that supports WebUSB
// Desktop app should have Bridge transport layer available as it is built-in, if it is not available we fucked up something.
<TroubleshootingTips
label={<Translation id="TR_TROUBLESHOOTING_DEVICE_NOT_DETECTED" />}
items={[
TROUBLESHOOTING_TIP_WEBUSB_ENVIRONMENT,
TROUBLESHOOTING_TIP_SUITE_DESKTOP,
TROUBLESHOOTING_TIP_RESTART_COMPUTER,
]}
data-testid="@connect-device-prompt/bridge-not-running"
/>
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes here. sorry for diff

@mroz22 mroz22 force-pushed the unreadeble-troubleshooting branch from 51dacde to 9113a35 Compare October 30, 2024 10:02
@mroz22 mroz22 marked this pull request as ready for review October 30, 2024 10:24
@mroz22 mroz22 requested a review from martykan as a code owner October 30, 2024 10:24
Copy link
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Only thing I noticed when testing is when toggling bridge implementations the error changes into "App can't communicate with device" momentarily. But that's probably not important

@mroz22 mroz22 merged commit 75af574 into develop Oct 30, 2024
64 checks passed
@mroz22 mroz22 deleted the unreadeble-troubleshooting branch October 30, 2024 13:45
@Hannsek
Copy link
Contributor

Hannsek commented Oct 30, 2024

@evgenysl Once you'll be testing that, please post here screenshots of how does it look now. 🙏🏻

@bosomt
Copy link
Contributor

bosomt commented Nov 20, 2024

This is what i see on 24.11.2 when i connect 1.3.3 device

Image

Info:

  • Suite version: web 24.11.2 (b44a924)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device:
  • Transport: WebUsbTransport

@bosomt
Copy link
Contributor

bosomt commented Nov 20, 2024

This is Node bridge and app with same device

image

Info:

  • Suite version: desktop 24.11.2 (b44a924)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.11.2 Chrome/128.0.6613.162 Electron/32.1.2 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device:
  • Transport: BridgeTransport 3.0.0-bundled.24.11.2

@mroz22
Copy link
Contributor Author

mroz22 commented Nov 20, 2024

Hmm I think it should have displayed something different. Could you please also post old bridge status page with that device?

@bosomt
Copy link
Contributor

bosomt commented Nov 22, 2024

Same device with old bridge running

image Screenshot 2024-11-22 at 10 45 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing instructions on landing page for old devices
6 participants