Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiny nitpick refactorings #14675

Merged
merged 2 commits into from
Oct 2, 2024
Merged

tiny nitpick refactorings #14675

merged 2 commits into from
Oct 2, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Oct 2, 2024 •
edited
Loading

tiny nitpicks:

  • removing useless destructing of messages in transport classes constructors
  • merging packages/suite/src/components/suite/troubleshooting/tips/BridgeStatus.tsx and merging packages/suite/src/components/suite/troubleshooting/tips/BridgeInstall.tsx into one file to save some lines of code by removing common imports and duplicated Wrapper component. cherry-picked from chore(suite): unreadable device tips improvements #14637

@mroz22 mroz22 marked this pull request as ready for review October 2, 2024 09:40
@mroz22 mroz22 requested review from Nodonisko and a team as code owners October 2, 2024 09:40
@mroz22 mroz22 merged commit e071138 into develop Oct 2, 2024
55 checks passed
@mroz22 mroz22 deleted the nitpicks branch October 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekrjpolak marekrjpolak marekrjpolak approved these changes

@Nodonisko Nodonisko Awaiting requested review from Nodonisko Nodonisko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroz22 @marekrjpolak