Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS version detection #16985

Open
komret opened this issue Feb 13, 2025 · 1 comment
Open

Fix macOS version detection #16985

komret opened this issue Feb 13, 2025 · 1 comment
Labels
bug Something isn't working as expected macOS MacOS related message-system Updates in secure message system config

Comments

@komret
Copy link
Contributor

komret commented Feb 13, 2025

Browsers (including Electron) report all Mac OS versions from 10.15.7 onwards as 10.15.7 to prevent fingerprinting. This makes our getOsVersion util unusable for Mac OS - for example, it cannot be reliably used in messsage system, see #16741. However, there is a way to circumvent it in desktop apps. It was partially replaced here, but it should be done everywhere in the app.

@komret komret added bug Something isn't working as expected macOS MacOS related message-system Updates in secure message system config labels Feb 13, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Feb 13, 2025
@Lemonexe
Copy link
Contributor

I was curious if there is any alternative at all in browser.
The desktopOsVersion is never available on Suite Web.
On chromium based browsers, we can use

window.navigator.userAgentData.getHighEntropyValues(['platform', 'platformVersion']).then(console.log)

But not available on Firefox or Safari..

But then again, Desktop is all we need..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected macOS MacOS related message-system Updates in secure message system config
Projects
Status: 🎯 To do
Development

No branches or pull requests

2 participants