Chore/message system catalina deprecation #16741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lemonexe
commented
Jan 30, 2025
| "conditions": [ | ||
| { | ||
| "os": { | ||
| "macos": "<10.16.0", |
There was a problem hiding this comment.
this should theoretically be correct, but it must be verified.
I guess that osVersion is using the first column in https://en.wikipedia.org/wiki/MacOS_version_history#Releases
So 10.15.x and below is what we want to target. Idk if Big Sur is 11 or 10.16, but it should work nevertheless.
This needs to be confirmed!
Lemonexe
force-pushed
the
chore/message-system-catalina-deprecation
branch
from
e5ac8e8 to
fa356c3
Compare
Lemonexe
force-pushed
the
chore/message-system-catalina-deprecation
branch
from
fa356c3 to
2b28d95
Compare
Lemonexe
had a problem deploying
to
develop-message
GitHub Actions
Error
|
🚀 Expo preview is ready!
|
Lemonexe
force-pushed
the
chore/message-system-catalina-deprecation
branch
from
2b28d95 to
fe61400
Compare
Lemonexe
force-pushed
the
chore/message-system-catalina-deprecation
branch
from
fe61400 to
90e6c92
Compare
|
Closing because of #16985. Most of our users on Catalina will be on 10.15.7 as that is the latest Catalina version. So they cannot be targeted without displaying the message to all Mac users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add message to warn Catalina users that they mustn't update their Suite to 25.3.x, as it'll probably stop working.
Although message-system does not yet support
desktopOsVersion(from nodeJS, added in #15789), this is fine, because the issue was, thatosVersioncan't distinguish Big Sur and those above. So targetting Catalina and below can be done just with the userAgentosVersion🙂Related Issue
Resolve #16693
Screenshots:
@coderabbitai ignore