docs(connect-explorer): connect-deeplink / mobile #14481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martykan
changed the title
trezor-ci
force-pushed
the
feat/native-connect-popup
branch
from
5572148 to
47deadd
Compare
martykan
force-pushed
the
feat/native-connect-popup
branch
3 times, most recently
from
5dea4aa to
ef51c96
Compare
martykan
force-pushed
the
doc/native-connect-popup
branch
from
164ecee to
9e64c06
Compare
martykan
force-pushed
the
feat/native-connect-popup
branch
from
55ee24f to
c7f9d1f
Compare
An error occurred while trying to automatically change base from
feat/native-connect-popup
to
develop
September 26, 2024 13:11
martykan
changed the title
martykan
force-pushed
the
doc/native-connect-popup
branch
3 times, most recently
from
bcafbfb to
635c797
Compare
Nodonisko
reviewed
Sep 27, 2024
martykan
force-pushed
the
doc/native-connect-popup
branch
from
635c797 to
dc74699
Compare
5 tasks
martykan
force-pushed
the
doc/native-connect-popup
branch
from
dc74699 to
ad09e32
Compare
mroz22
reviewed
Oct 15, 2024
Comment on lines
+126
to
+130
| if (!this.messagePromises[id]) { | ||
| // Most likely old ID, ignore | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
feels like it would deserve a standalone commit maybe. nitpick.
mroz22
approved these changes
Oct 15, 2024
| @@ -143,6 +145,7 @@ export const init = | |||
| // Get default coreMode from URL params (?core-mode=auto) | |||
| const urlParams = new URLSearchParams(window.location.search); | |||
| const coreMode = (urlParams.get('core-mode') as ConnectOptions['coreMode']) || 'auto'; | |||
| const deeplink = urlParams.get('deeplink') === 'true'; // TODO | |||
There was a problem hiding this comment.
I imagine, that in the end, deeplink will be only one of the core modes maybe (only available if some conditions are met, such as registering callbacks etc).
martykan
force-pushed
the
doc/native-connect-popup
branch
from
ad09e32 to
0530156
Compare
mroz22
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a section about mobile to the index page, including quickstart guide.
Add a page documenting the deeplink URL spec.
Add the option to open and receive deeplinks from Connect Explorer.
Link: https://dev.suite.sldev.cz/connect/doc/native-connect-popup/
Related Issue
Resolve #14533