Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/desktop user agent #14495

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Feat/desktop user agent #14495

merged 3 commits into from
Oct 1, 2024

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented Sep 24, 2024

Description

  • add Suite version to user agent of requests going from desktop app
  • version is correctly added to the user agent

If needed, we can change the hardcoded Trezor Suite name to a dynamic value in the future.

Related Issue

Screenshots:

Cloudflare:
Screenshot 2024-09-24 at 10 18 20

@tomasklim
Copy link
Member Author

/rebase

Copy link

@trezor-ci trezor-ci force-pushed the feat/desktop-user-agent branch from 2156dca to 94bf367 Compare September 25, 2024 06:28
@tomasklim tomasklim merged commit 2109d00 into develop Oct 1, 2024
85 of 86 checks passed
@tomasklim tomasklim deleted the feat/desktop-user-agent branch October 1, 2024 11:56
@bosomt
Copy link
Contributor

bosomt commented Oct 2, 2024

QA OK

image

Info:

  • Suite version: desktop 24.10.1 (3017e58)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.10.1 Chrome/126.0.6478.234 Electron/31.6.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.8.1 regular (revision 632b9561559b7ab6824bb7eeac072874e07b7b82)
  • Transport: BridgeTransport 3.0.0-bundled.24.10.1

@tomasklim
Copy link
Member Author

@bosomt it was like that even before. This change is for desktop and it is probably not possible to test

@STew790
Copy link
Contributor

STew790 commented Oct 3, 2024

I just checked it with Tali and it is OK from him as well 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants