-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finetune install connect test #14518
Conversation
it looks like it can't resolve imports from sinclair. It reminded me of this script that is replacing imports from monorepo with actual ones https://github.com/trezor/trezor-suite/blob/develop/scripts/replace-imports.sh#L19 but it shouldn't be the case here also .mjs is suspicious. could be that I just need some additional configuration |
usb lib depends on w3c-web-usb types. so we probably need to make sure that it is always installed ![]() this should help I think 74c7bca |
b355ef3
to
d80609e
Compare
d80609e
to
3f1f423
Compare
packages/connect/package.json
Outdated
@@ -91,6 +91,7 @@ | |||
"devDependencies": { | |||
"@trezor/trezor-user-env-link": "workspace:*", | |||
"@types/karma": "^6.3.8", | |||
"@types/w3c-web-usb": "^1.0.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shows up as an unused dependency, which makes sense since it's used in @packages/transport
not @packages/connect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3f1f423
to
5e7cf7f
Compare
5e7cf7f
to
1c267f3
Compare
there is a test that connect is installable from npm, types work, and we didn't screw up.
the problem is that it is now falling in CI so we might have screwed up actually.
to get this information earlier, I suggest extending it also to beta channel.
the problem is that I don't understand what is going on there right now. Maybe @martykan got some clue