chore(components): update CollapsibleBox component #14532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seibei-iguchi
force-pushed
the
chore/update-staking-modal
branch
3 times, most recently
from
b9d9c3f to
f10b4f0
Compare
seibei-iguchi
force-pushed
the
chore/update-staking-modal
branch
2 times, most recently
from
41aabd8 to
6ba9c96
Compare
seibei-iguchi
requested review from
mroz22,
szymonlesisz,
martykan and
jvaclavik
as code owners
seibei-iguchi
force-pushed
the
chore/update-staking-modal
branch
from
6ba9c96 to
84ff575
Compare
martykan
reviewed
Sep 26, 2024
| margin: 0; | ||
| border: 0; | ||
|
|
||
| /* CollapsibleBox content, fix for nested sticky elements */ |
There was a problem hiding this comment.
We need this to have working scrolling inside the box, can you suggest an alternate solution?
See here for example:
https://dev.suite.sldev.cz/connect/chore/update-staking-modal/methods/bitcoin/signTransaction/?submethod=multisig
vs desired behavior
https://dev.suite.sldev.cz/connect/develop/methods/bitcoin/signTransaction/?submethod=multisig
There was a problem hiding this comment.
I will try to think of something:)
There was a problem hiding this comment.
I think I fixed this, waiting for deployment.
seibei-iguchi
force-pushed
the
chore/update-staking-modal
branch
from
84ff575 to
9f0b574
Compare
seibei-iguchi
force-pushed
the
chore/update-staking-modal
branch
from
9f0b574 to
c0f7b9e
Compare
jvaclavik
reviewed
Sep 26, 2024
packages/components/src/components/CollapsibleBox/CollapsibleBox.tsx
Outdated
Show resolved
Hide resolved
...e/modals/ReduxModal/UserContextModal/TxDetailModal/AdvancedTxDetails/IODetails/IODetails.tsx
Show resolved
Hide resolved
packages/suite/src/components/wallet/TransactionItem/CoinjoinBatchItem.tsx
Show resolved
Hide resolved
seibei-iguchi
force-pushed
the
chore/update-staking-modal
branch
from
c0f7b9e to
73c9444
Compare
jvaclavik
approved these changes
Sep 26, 2024
|
resolve #14397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots:
Before
After