-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T3W1 support in Suite #14608
T3W1 support in Suite #14608
Conversation
1ab3f65
to
fc7a0cf
Compare
@@ -6,6 +6,7 @@ export enum DeviceModelInternal { | |||
T2B1 = 'T2B1', | |||
T3B1 = 'T3B1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran yarn update-protobuf
locally to see if it is in sync.
- The addition of T3W1 is in sync (no diffs against this PR) ✔️
- But it removed T3B1
⚠️
👉 it's not related to this PR but someone should fix T3B1 in firmware repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not happening anymore, at least not on my machine :)
9738c79
to
c25468d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idon't see any problem here
c25468d
to
274ec03
Compare
Fingerprint is changed, new EAS Build(s) are now in pipeline. Build with commit d689971
Fingerprint diff[
{
"op": "changed",
"source": {
"type": "contents",
"id": "expoConfig",
"contents": "{\"android\":{\"adaptiveIcon\":{\"backgroundColor\":\"#E59D17\",\"foregroundImage\":\"./assets/appIcon_android.png\",\"monochromeImage\":\"./assets/appIcon_android.png\"},\"intentFilters\":[{\"action\":\"VIEW\",\"autoVerify\":true,\"category\":[\"BROWSABLE\",\"DEFAULT\"],\"data\":[{\"host\":\"dev.suite.sldev.cz\",\"pathPattern\":\"/connect/.*/.*/deeplink/.*\",\"scheme\":\"https\"},{\"host\":\"dev.suite.sldev.cz\",\"pathPattern\":\"/connect/.*/deeplink/.*\",\"scheme\":\"https\"}]}],\"package\":\"io.trezor.suite.preview\",\"permissions\":[\"android.permission.CAMERA\"]},\"extra\":{\"commitHash\":\"4c743aff66e3e43272acef9dbdc0e27ea9488024\",\"eas\":{\"projectId\":\"15998f8a-e75c-4b60-959d-6f68e5ff4936\"}},\"ios\":{\"associatedDomains\":[\"applinks:dev.suite.sldev.cz\"],\"bundleIdentifier\":\"io.trezor.suite.preview\",\"icon\":\"./assets/preview/appIcon.png\",\"infoPlist\":{\"ITSAppUsesNonExemptEncryption\":false,\"NSAppTransportSecurity\":{\"NSAllowsArbitraryLoads\":true,\"NSExceptionDomains\":{\"data.trezor.io\":{\"NSExceptionAllowsInsecureHTTPLoads\":true,\"NSIncludesSubdomains\":true},\"localhost\":{\"NSExceptionAllowsInsecureHTTPLoads\":true}}},\"NSCameraUsageDescription\":\"$(PRODUCT_NAME) needs access to your Camera to scan your XPUB.\",\"NSFaceIDUsageDescription\":\"$(PRODUCT_NAME) needs Face ID and Touch ID to keep sensitive data about your portfolio private.\",\"NSMicrophoneUsageDescription\":\"This app does not require access to the microphone.\",\"UIRequiredDeviceCapabilities\":[\"armv7\"]},\"supportsTablet\":true},\"name\":\"Trezor Suite Lite Preview\",\"orientation\":\"portrait\",\"owner\":\"trezorcompany-develop\",\"platforms\":[\"android\",\"ios\"],\"plugins\":[\"./plugins/withGradleProperties.js\",\"./plugins/withRemoveXcodeLocalEnv.js\",\"./plugins/withRemoveiOSNotificationEntitlement.js\",\"@trezor/react-native-usb/plugins/withUSBDevice.js\",[\"./plugins/withAndroidMainActivityAttributes.js\",{\"android:allowBackup\":false}],[\"@config-plugins/detox\",{\"subdomains\":\"*\"}],[\"@sentry/react-native/expo\",{\"organization\":\"satoshilabs\",\"project\":\"suite-native\",\"url\":\"https://sentry.io/\"}],[\"expo-build-properties\",{\"android\":{\"minSdkVersion\":28},\"ios\":{\"deploymentTarget\":\"14.0\"}}],[\"expo-camera\",{\"cameraPermission\":\"Allow $(PRODUCT_NAME) to access camera for QR code scanning.\",\"microphonePermission\":false,\"recordAudioAndroid\":false}],[\"expo-font\",{\"fonts\":[\"../../packages/theme/fonts/TTSatoshi-DemiBold.otf\",\"../../packages/theme/fonts/TTSatoshi-Medium.otf\",\"../../suite-common/icons/iconFontsMobile/TrezorSuiteIcons.ttf\"]}],[\"expo-image-picker\",{\"microphonePermission\":false,\"photosPermission\":\"Allow $(PRODUCT_NAME) to access your photos to let you import QR code images.\"}]],\"runtimeVersion\":\"9\",\"scheme\":\"trezorsuitelite\",\"sdkVersion\":\"51.0.0\",\"slug\":\"trezor-suite-preview\",\"splash\":{\"backgroundColor\":\"#25292E\",\"image\":\"./assets/splash_icon.png\",\"resizeMode\":\"contain\"},\"updates\":{\"requestHeaders\":{\"expo-channel-name\":\"preview\"},\"url\":\"https://u.expo.dev/15998f8a-e75c-4b60-959d-6f68e5ff4936\"},\"userInterfaceStyle\":\"automatic\",\"version\":\"24.10.2\"}",
"reasons": [
"expoConfig"
],
"hash": "0859f6e51af67f14011fbf9d7158107a8063e0c8"
}
}
]
|
🚀 Expo preview is ready!
|
274ec03
to
12cd351
Compare
@mroz, please recheck the connect part and protobuf. I lowered minimum firmware version from concrete values to 1.0.0 or 2.0.0 at some places. My assumption is that while this should have no impact on functionality, it simplifies adding new devices in future, because we usually don't know the exact firmware version that will be released at the time of adding support to Suite. I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suite part LGTM 🚀
@@ -15,7 +15,6 @@ type DeviceScreenPaginationProps = { | |||
onPress: () => void; | |||
}; | |||
|
|||
const T2B1_BUTTON_COLOR = '#2B2D2B'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not remove this const, it's not clear what's is that value now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put it back in 7552647, but the naming is quite weird, it says T2B1, but is not used for T2B1 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one nit for native part
/rebase |
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11591101021 |
Rebasing failed, please rebase manually. |
…ods on all versions
7552647
to
d689971
Compare
Added support for T3W1
FW version
"2.99.99",pubkeys
"you shall not pass", etc.)