Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(staking): update instant stake notification #14628

Merged

Conversation

dev-pvl
Copy link
Contributor

@dev-pvl dev-pvl commented Sep 30, 2024

Description

Staking: Instant stake notification visual update.

Related Issue

Resolve #13941

Screenshots:

Screenshot
Screenshot2

TR_STAKING_INSTANT_UNSTAKING: {
id: 'TR_INSTANT_UNSTAKING',
defaultMessage: 'Unstaked instantly',
},
TR_STAKING_INSTANTLY_STAKED: {
id: 'TR_STAKING_INSTANTLY_STAKED',
defaultMessage:
"You've instantly staked {amount} {symbol}. {days, plural, =0 {} one {The remaining {symbol} is staked within # day.} other { The remaining {symbol} is staked within # days}}",
"You've instantly staked {amount} {symbol}. {days, plural, =0 {} one {The remaining {symbol} will be staked within # day.} other { The remaining {symbol} is staked within # days}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"You've instantly staked {amount} {symbol}. {days, plural, =0 {} one {The remaining {symbol} will be staked within # day.} other { The remaining {symbol} is staked within # days}}",
"You've instantly staked {amount} {symbol}. {days, plural, =0 {} one {The remaining {symbol} will be staked within # day.} other { The remaining {symbol} will be staked within # days}}",

@tomasklim tomasklim force-pushed the feat/update-instant-stake-notification branch from ba46cda to 894c66e Compare September 30, 2024 17:29
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-30 at 19 25 33
LGTM

@tomasklim tomasklim enabled auto-merge (rebase) September 30, 2024 17:30
@tomasklim tomasklim merged commit 0c803d4 into trezor:develop Sep 30, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staking: Instant stake notification eye grabbing visual update
2 participants