feat(suite-native): make token selectors network agnostic #14633
Conversation
vytick
force-pushed
the
feat/native/polygon-tokens
branch
2 times, most recently
from
e5a5b55 to
6a6f55a
Compare
| { size: 500 }, | ||
| ); | ||
|
|
||
| export const selectAccountOrTokenAccountTransactions = ( |
There was a problem hiding this comment.
Name is strange, it returns only transactions. Something like selectAccountTokenTransactions is more clear
There was a problem hiding this comment.
It returns either all txns for whole account (eg. eth + tokens)or only for some token (usdc on eth)
| isTransactionWithTokenTransfers(transaction)), | ||
| ), | ||
| ) as WalletAccountTransaction[], | ||
| { size: 500 }, |
There was a problem hiding this comment.
I don't think there will be 500 accounts
| ), | ||
| ), | ||
| ) as WalletAccountTransaction[], | ||
| { size: 500 }, |
There was a problem hiding this comment.
I don't think we need such a big number, something like 50 will be also fine there because there won't more than one mounted instance of component that uses this selector
There was a problem hiding this comment.
👍 Will change. I kept the number from renamed and moved ethereum selector.
|
Also E2E seems to fail |
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11133164772 |
trezor-ci
force-pushed
the
feat/native/polygon-tokens
branch
from
e8dde21 to
1c2056e
Compare
|
@STew790 Please test, that everything works as before:
|
|
QA OK
Info |
This PR does not touch any UI so far, only contains changes for working with tokens.
Related Issue
Part of #14196
Screenshots:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-30.at.22.24.56.mp4