-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the EVM legacy discovery error on old firmware #14648
Conversation
return value.concat( | ||
<div key={account.symbol}> | ||
{network.name}: {getAccountError(account.error)} | ||
{network.name} {accountTypeDisplay}:{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means, that if it is normal, there is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, let me remove the " "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, now the space will be only when the type is not normal
3abb6ba
to
f2399fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f2399fa
to
5b0ae32
Compare
sorry, no idea how I could forget this. reworded. |
The copywriting is clear and concise, directly explaining the issue. However, the [Retry] CTA feels out of place. From the user's perspective, a CTA to update the firmware would be more appropriate, as retrying will lead to the same result without the update. Since we can't change the flow at this point, how about adding '(see the blue banner above)' at the end of the body text? |
Sure, I will add this note |
2fda6dc
to
1a23979
Compare
2b193f8
to
025e472
Compare
025e472
to
62c4892
Compare
Description
Changed the error message for non-normal EVM account types, when discovery error occurs.
Related Issue
Resolve #14638
Screenshots: