Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wallet-config): order networks #14659

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore(wallet-config): order networks #14659

merged 2 commits into from
Oct 1, 2024

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented Oct 1, 2024 •
edited
Loading

Description

  • approved by Hans
  • order networks by "popularity"

Related Issue

Resolve

Screenshots:

Screenshot 2024-10-01 at 15 01 43

marekrjpolak
marekrjpolak approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine, once the unit tests are fixed.

@tomasklim
Copy link
Member Author

/rebase

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11127930343

@trezor-ci trezor-ci force-pushed the chore/networks-order branch from 4fe2b31 to 4a738a7 Compare October 1, 2024 15:00
@tomasklim tomasklim force-pushed the chore/networks-order branch from 4a738a7 to f49da02 Compare October 1, 2024 15:36
@tomasklim tomasklim enabled auto-merge (rebase) October 1, 2024 16:56
@tomasklim tomasklim merged commit a747293 into develop Oct 1, 2024
17 of 24 checks passed
@tomasklim tomasklim deleted the chore/networks-order branch October 1, 2024 17:17
@bosomt
Copy link
Contributor

bosomt commented Oct 1, 2024

QA OK

image

Info:

  • Suite version: desktop 24.10.0 (2187dc0)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.10.0 Chrome/126.0.6478.234 Electron/31.6.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.8.1 regular (revision 632b9561559b7ab6824bb7eeac072874e07b7b82)
  • Transport: BridgeTransport 3.0.0-bundled.24.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekrjpolak marekrjpolak marekrjpolak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomasklim @bosomt @marekrjpolak @Lemonexe