Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): bottom sheet flashlist #14681

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat(mobile): bottom sheet flashlist #14681

merged 1 commit into from
Oct 11, 2024

Conversation

Nodonisko
Copy link
Contributor

Description

  1. Created special version of BottomSheet for FlashList
  2. Fixed some bugs related to scrolling
  3. Staking toast messages are now visible when BottomSheetFlashlist is opened
  4. Some other bugfixes etc.

Related Issue

Resolve #14503

Screenshots:

@Nodonisko Nodonisko requested a review from a team as a code owner October 2, 2024 11:16
@Nodonisko Nodonisko force-pushed the feat/flashlist-bottom-sheet branch from c08b5c8 to 9593464 Compare October 2, 2024 11:21
@Nodonisko Nodonisko added the mobile Suite Lite issues and PRs label Oct 2, 2024
@yanascz
Copy link
Contributor

yanascz commented Oct 9, 2024

Is the double spacing between items supposed to be fixed in this PR?
Also the Select Account title is now missing.

image

@Nodonisko Nodonisko force-pushed the feat/flashlist-bottom-sheet branch 2 times, most recently from c7dcc56 to e066e02 Compare October 11, 2024 08:13
@Nodonisko
Copy link
Contributor Author

Fix for bad groups is not part of this PR, will do follow-up. Select Account title should it's intentionally removed according to Sheny.

@Nodonisko Nodonisko force-pushed the feat/flashlist-bottom-sheet branch from e066e02 to ac7dbd3 Compare October 11, 2024 09:27
@Nodonisko Nodonisko merged commit decfe32 into develop Oct 11, 2024
87 of 88 checks passed
@Nodonisko Nodonisko deleted the feat/flashlist-bottom-sheet branch October 11, 2024 11:25
komret pushed a commit that referenced this pull request Nov 14, 2024
@Nodonisko @komret
feat(mobile): bottom sheet flashlist (#14681)
781d07a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanascz yanascz yanascz approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BottomSheet refactor to better support other ScrollViews
2 participants
@Nodonisko @yanascz