connect - core in suite-desktop by mroz22 · Pull Request #14690 · trezor/trezor-suite

mroz22 · 2024-10-02T15:03:06Z

So far only some preliminary research and exploration of replacing connect-popup with suite-desktop. My general idea is to merge this feature behind debug. The motivation is that there are similar UX problems to be solved for both core-in-suite-native and core-in-suite-desktop so it makes sense to me to have some playground available for both.

suite-desktop:

in dev or when --expose-connect-ws flag is on, suite-desktop opens websocket on 8090 and accepts connect calls here.
the 1st commit has support for inter-module inducted window-focus and window-blur. it probably needs some more polishing.

connect-web:

added new imp core-in-suite-desktop. what is a better name? core-in-ws-server?
this impl should later be available also from base connect package. And also from connect-webextension. I need to discuss this with @karliatto

mroz22 · 2024-10-29T08:07:02Z

+
+    mainThreadEmitter.on('blur-window', () => {
+        app.hide();
+    });


one preliminary question - is it the correct way to achieve inter-module focus-window and blur-window? if yes, then of course code duplication needs to be solved.

cc @marekrjpolak, @martykan

We already have handlers in window-controls that respond to ipcMain app/hide and app/focus

However it can only focus an existing window, not recreate it

github-actions · 2024-11-11T12:54:56Z

🚀 Expo preview is ready!

Project → trezor-suite-preview
Platforms → android, ios
Scheme → trezorsuitelite
Runtime Version → 11
More info

Learn more about 𝝠 Expo Github Action

martykan · 2024-11-18T13:11:56Z

Current state:

Suite runs Websocket server at http://localhost:2335/connect-ws
New Core mode in Connect (suite-desktop) that communicates with said WS
Modal that shows info about the method being called, needs to be confirmed every time
Security info about the process that created the connection + web origin header

Missing features:

Support better device modals (refactor modal state)
- ConfirmAddressModal
- ConfirmXpubModal
- TransactionReviewModal
Special methods with UI requests
- getAccountInfo
  - SELECT_ACCOUNT
- composeTransaction
  - SELECT_FEE, UPDATE_CUSTOM_FEE, INSUFFICIENT_FUNDS
Permissions handling
- Keep using internal Connect logic - but need different settings → Second instance of connect? Different API
- Or skip internal Connect logic and use wrapper?

…over websocket

…ettings page

…isting http receiver

mroz22

🦭 ✅

…upied

- #14690 introduced dependency on @trezor/suite-desktop-api in @suite-common/connect-init - The ultimate solution would be to split that logic to a new package and remove the dependency on desktop-api from connect-init

mroz22 force-pushed the connect-desktop branch 2 times, most recently from 10a19b9 to 813585f Compare October 3, 2024 06:00

mroz22 mentioned this pull request Oct 3, 2024

chore(suite): remove synchronize of connect calls #14692

Closed

MiroslavProchazka added the build-desktop This will trigger the build of desktop apps for your PR label Oct 3, 2024

mroz22 mentioned this pull request Oct 3, 2024

feat(connect): dispatch call in progress event - needed for immediate… #14717

Closed

Hannsek added build-desktop This will trigger the build of desktop apps for your PR and removed build-desktop This will trigger the build of desktop apps for your PR labels Oct 7, 2024

mroz22 mentioned this pull request Oct 7, 2024

wip: core-in-whatever #14740

Closed

mroz22 force-pushed the connect-desktop branch 2 times, most recently from 6aa7d61 to 8e58f34 Compare October 29, 2024 07:58

mroz22 changed the title ~~[wip] connect - core in suite-desktop~~ [lets talk] connect - core in suite-desktop Oct 29, 2024

mroz22 commented Oct 29, 2024

View reviewed changes

karliatto reviewed Oct 29, 2024

View reviewed changes

Comment thread packages/connect-web/src/impl/core-in-suite-desktop.ts

mroz22 force-pushed the connect-desktop branch from 8e58f34 to b85894c Compare November 6, 2024 09:07

Hannsek added build-desktop This will trigger the build of desktop apps for your PR and removed build-desktop This will trigger the build of desktop apps for your PR labels Nov 10, 2024

martykan force-pushed the connect-desktop branch from b85894c to ff0afd7 Compare November 11, 2024 12:38

martykan force-pushed the connect-desktop branch from 4a816ff to 9be558b Compare November 18, 2024 13:05

martykan force-pushed the connect-desktop branch from 9be558b to b1630f7 Compare November 18, 2024 13:30

mroz22 marked this pull request as ready for review November 21, 2024 14:42

mroz22 requested review from marekrjpolak and szymonlesisz as code owners November 21, 2024 14:42

mroz22 changed the title ~~[lets talk] connect - core in suite-desktop~~ connect - core in suite-desktop Nov 21, 2024

mroz22 commented Nov 21, 2024

View reviewed changes

Comment thread packages/connect-web/src/impl/core-in-suite-desktop.ts Outdated

Comment thread packages/connect-web/src/impl/core-in-suite-desktop.ts

Comment thread packages/connect/src/constants/errors.ts

martykan force-pushed the connect-desktop branch 2 times, most recently from 2b772b3 to d0ee74b Compare November 22, 2024 09:25

mroz22 and others added 9 commits November 25, 2024 11:23

feat(suite-desktop): add option to expose connect interface publicly …

ccbb8d7

…over websocket

feat(connect): add core-in-desktop mode

3c3994b

feat(connect-explorer): add option to use core-in-desktop mode from s…

1956233

…ettings page

chore(suite-desktop-core): separate connect ws logic, combine with ex…

8af463c

…isting http receiver

chore(suite): move connect popup handling to web

8ee3500

feat(suite): connect popup modals

68daea4

feat(suite): show descriptive method title in connect popup

b37a896

feat(suite): connect popup display connecting process and web origin

344ace2

chore(suite): interrupt discovery on connect popup

b1125c6

martykan force-pushed the connect-desktop branch from d0ee74b to b1125c6 Compare November 25, 2024 10:25

mroz22 commented Nov 25, 2024

View reviewed changes

martykan approved these changes Nov 25, 2024

View reviewed changes

fix(suite-desktop-core): init connect popup only if really enabled

2e1fa63

martykan force-pushed the connect-desktop branch from fdb3d98 to 21ec6ac Compare November 25, 2024 13:29

fix(suite-desktop-core): don't fail hard if http-receiver port is occ…

9bcddac

…upied

martykan force-pushed the connect-desktop branch from 21ec6ac to 9bcddac Compare November 25, 2024 13:46

martykan merged commit cba164c into develop Nov 25, 2024

martykan deleted the connect-desktop branch November 25, 2024 14:30

matejkriz mentioned this pull request Dec 16, 2024

chore(ci): fix EAS builds #15973

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

connect - core in suite-desktop#14690

connect - core in suite-desktop#14690
martykan merged 11 commits intodevelopfrom
connect-desktop

mroz22 commented Oct 2, 2024 •

edited

Loading

Uh oh!

mroz22 Oct 29, 2024

Uh oh!

martykan Oct 29, 2024 •

edited

Loading

Uh oh!

martykan Oct 29, 2024

Uh oh!

Uh oh!

github-actions Bot commented Nov 11, 2024 •

edited

Loading

Uh oh!

martykan commented Nov 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mroz22 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

mroz22 commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mroz22 Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

martykan Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martykan Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martykan commented Nov 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mroz22 left a comment

Choose a reason for hiding this comment

🦭 ✅

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mroz22 commented Oct 2, 2024 •

edited

Loading

martykan Oct 29, 2024 •

edited

Loading

github-actions Bot commented Nov 11, 2024 •

edited

Loading