feat(coinmarket): disable 'you buy' select in trezor btc only firmware #14694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adderpositive
added
feature
tomasklim
reviewed
Oct 3, 2024
| const { currencySelect, cryptoSelect } = context.getValues(); | ||
| const supportedCryptoCurrencies = buyInfo?.supportedCryptoCurrencies; | ||
| const isBitcoinOnly = device?.firmwareType === FirmwareType.BitcoinOnly; |
There was a problem hiding this comment.
please use util hasBitcoinOnlyFirmware
There was a problem hiding this comment.
please refactor it on all places in trade section (in case it is also somewhere else in suite 🥺 🙏 you can too)
There was a problem hiding this comment.
look for device?.firmwareType === FirmwareType.BitcoinOnly and device.firmwareType === FirmwareType.BitcoinOnly
tomasklim
approved these changes
Oct 4, 2024
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11177366678 |
trezor-ci
force-pushed
the
feat/coinmarket-disable-select
branch
from
4fcf30e to
9d92a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You buydropdown should be displayed to indicate BTC, but disabled.Related
Resolves #14693