fix(suite-native): enable to confirm receive address outside our app #14732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodonisko
reviewed
Oct 7, 2024
packages/react-native-usb/android/src/main/java/io/trezor/rnusb/ReactNativeUsbModule.kt
Outdated
Show resolved
Hide resolved
🤖 Open this link on your Android devices (or scan the QR code) to install the app: |
Nodonisko
approved these changes
Oct 10, 2024
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11276936994 |
- We are closing device connection on going to background, so we have to reopen it once needed. We can open the device even on background. But Suite has to be still running, not killed. - Closing all the devices OnActivityEntersBackground is a good thing because we want to allow other apps (like browser) to work with the Trezor too and it is a good practice to frees up system resources.
trezor-ci
force-pushed
the
fix/native/send-flow-review-outside-app
branch
from
b645ec2 to
b7c4f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve #14716