Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify types for setTimeout return type to address the NodeJS types leak issue #15727

Merged
merged 1 commit into from
Dec 3, 2024
Merged

chore: unify types for setTimeout return type to address the NodeJS types leak issue #15727

merged 1 commit into from
Dec 3, 2024

Conversation

peter-sanderson
Copy link
Contributor

@peter-sanderson peter-sanderson commented Dec 3, 2024 •
edited
Loading 

/**
 * Hack to workaround NodeJS.Timeout vs number type issue.
 *
 * Some reads on the topic:
 *  - https://stackoverflow.com/questions/45802988/typescript-use-correct-version-of-settimeout-node-vs-window
 *  - https://guilhermesimoes.github.io/blog/making-settimeout-return-number-in-typescript
 *
 */

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 16
  • More info

Learn more about 𝝠 Expo Github Action

@Lemonexe
Copy link
Contributor

Lemonexe commented Dec 3, 2024

Looks good, but comments above, also lint errors..

Lemonexe
Lemonexe approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@peter-sanderson peter-sanderson merged commit 3f34981 into develop Dec 3, 2024
68 checks passed
@peter-sanderson peter-sanderson deleted the type-timer-into-utils branch December 3, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemonexe Lemonexe Lemonexe approved these changes

@Nodonisko Nodonisko Nodonisko left review comments

@karliatto karliatto Awaiting requested review from karliatto karliatto is a code owner

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

@tomasklim tomasklim Awaiting requested review from tomasklim tomasklim is a code owner

@martykan martykan Awaiting requested review from martykan martykan is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

@jvaclavik jvaclavik Awaiting requested review from jvaclavik

@adamhavel adamhavel Awaiting requested review from adamhavel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-sanderson @Lemonexe @Nodonisko