chore(suite): add priority fee network feature #16342

enjojoy · 2025-01-14T10:07:16Z

Description

Related Issue

Resolve #16438

Screenshots:

github-actions · 2025-01-14T10:11:34Z

🚀 Expo preview is ready!

Project → trezor-suite-preview
Platforms → android, ios
Scheme → trezorsuitelite
Runtime Version → 26
More info

Learn more about 𝝠 Expo Github Action

packages/blockchain-link-types/src/responses.ts

packages/connect/src/api/blockchainEstimateFee.ts

packages/connect/src/types/api/blockchainEstimateFee.ts

suite-common/wallet-config/src/networksConfig.ts

tomasklim · 2025-01-17T14:56:28Z

packages/blockchain-link-types/src/responses.ts

 export interface EstimateFee {
    type: typeof RESPONSES.ESTIMATE_FEE;
    payload: {
        feePerUnit: string;
        feePerTx?: string;
        feeLimit?: string;
+        eip1559?: {


Can be imported from Blockbook

tomasklim · 2025-01-17T14:57:36Z

suite-common/wallet-core/src/blockchain/blockchainThunks.ts

            const result = await TrezorConnect.blockchainEstimateFee({
                coin: network.symbol,
                request: {
                    blocks: [2],
+                    feeLevels: 'smart',


what is it?

It's needed for BlockchainEstimateFee method in connect. If the feeLevels are "smart", they are being created using FeeLevels.load method

which triggers loadMisc method that builds levels for 1559

It was there before but it wasn't implemented for ethereum

If they're not smart then it returns just one level which is the same as the response from blockbook

aha, this issue is still open #9185 so I don't know if it will start working out of the box

tomasklim · 2025-01-17T15:02:59Z

packages/connect/src/api/bitcoin/Fees.ts

+            if (response.eip1559) {
+                const eip1559LevelKeys = ['low', 'medium', 'high'] as const;
+
+                const { eip1559, ...baseLevel } = response;


what is this good for? ...baseLevel

tomasklim · 2025-01-17T15:05:49Z

packages/connect/src/api/bitcoin/Fees.ts

+                    { ...baseLevel, label: 'normal' as const, blocks: -1, ethFeeType: 'legacy' },
+                    ...eip1559Levels,


I don't think this makes sense.

normal level is probably low. Lowest fee to make it through

How about, if there is eip1559 available, let's do something like this:

low level eip1559 + normal legacy level

medium level eip1559 + normal legacy level increased by some constant

high level eip1559 + normal legacy level increased by some bigger constant

I am struggling if the constant is needed but probably yes as users can use old fw without eip1559 support.

If eip1559 is available for specific network, suite will check if eip1559 values are available and if not it will fallback to legacy.

But please wait for @martykan @marekrjpolak for their opinions

I would just spread eip levels and add legacy gas there

packages/connect/src/api/bitcoin/Fees.ts

tomasklim · 2025-01-24T16:57:20Z

packages/suite/src/support/messages.ts

+    FEE_LEVEL_MEDIUM: {
+        defaultMessage: 'Medium',
+        id: 'FEE_LEVEL_MEDIUM',
+    },


No need to introduce new level

tomasklim · 2025-01-24T16:58:06Z

packages/suite/src/support/messages.ts

@@ -6131,6 +6135,14 @@ export default defineMessages({
        id: 'TR_DATA',
        defaultMessage: 'Data',
    },
+    TR_MAX_PRIORITY_FEE_PER_GAS: {
+        id: 'TR_MAX_PRIORITY_FEE_PER_GAS',
+        defaultMessage: 'Max priority fee per gas',


Suggested change

defaultMessage: 'Max priority fee per gas',

defaultMessage: 'Max priority fee',

tomasklim · 2025-01-24T16:58:18Z

packages/suite/src/support/messages.ts

+    },
+    TR_MAX_FEE_PER_GAS: {
+        id: 'TR_MAX_FEE_PER_GAS',
+        defaultMessage: 'Max fee per gas',


Suggested change

defaultMessage: 'Max fee per gas',

defaultMessage: 'Max fee',

tomasklim · 2025-01-24T16:58:59Z

packages/components/src/components/Card/Card.tsx

@@ -34,12 +34,15 @@ export const allowedCardFrameProps = [
 ] as const satisfies FramePropsKeys[];
 type AllowedFrameProps = Pick<FrameProps, (typeof allowedCardFrameProps)[number]>;

-const Container = styled.div<{ $fillType: FillType } & TransientProps<AllowedFrameProps>>`
+const Container = styled.div<


probably some other (new) component than Card should be used for this

tomasklim · 2025-01-24T17:02:13Z

packages/suite/src/components/wallet/Fees/Fees.tsx

    ...props
 }: FeesProps<TFieldValues>) => {
    // Type assertion allowing to make the component reusable, see https://stackoverflow.com/a/73624072.
+    const shouldUsePriorityFees = network?.features?.includes('eip1559');


Suggested change

const shouldUsePriorityFees = network?.features?.includes('eip1559');

const shouldUsePriorityFees = getNetworkFeatures(symbol).includes("eip1559");

tomasklim · 2025-01-24T17:02:23Z

packages/suite/src/components/wallet/Fees/Fees.tsx

    composedLevels?: PrecomposedLevels | PrecomposedLevelsCardano;
    label?: TranslationKey;
    rbfForm?: boolean;
    helperText?: React.ReactNode;
+    network: Network;


network not needed here, you have account symbol

tomasklim · 2025-01-24T17:04:59Z

suite-common/wallet-utils/src/sendFormUtils.ts

@@ -146,7 +146,7 @@ export const prepareEthereumTransaction = (txInfo: EthTransactionData) => {
        chainId: txInfo.chainId,
        nonce: numberToHex(txInfo.nonce),
        gasLimit: numberToHex(txInfo.gasLimit),
-        gasPrice: numberToHex(toWei(txInfo.gasPrice, 'gwei')),
+        gasPrice: numberToHex(toWei(txInfo.gasPrice || '0', 'gwei')),


In case of legacy, it should probably fail with gasPrice undefined? It will fail with 0 anyways.

tomasklim · 2025-01-24T17:06:09Z

suite-common/wallet-core/src/send/sendFormEthereumThunks.ts

-    const feeInGwei = calculateEthFee(toWei(feeLevel.feePerUnit, 'gwei'), feeLevel.feeLimit || '0');
+    const feeInGwei = calculateEthFee(
+        toWei(feeLevel.feePerUnit || '0', 'gwei'),
+        feeLevel.feeLimit || '0',


note: feeLimit should probably not be undefined. never

tomasklim · 2025-01-24T17:10:28Z

packages/suite/src/components/wallet/Fees/FeeDetails.tsx

                {networkType === 'bitcoin' && <BitcoinDetails {...props} />}
                {networkType === 'ethereum' && <EthereumDetails {...props} />}
-                {networkType === 'ripple' && <RippleDetails {...props} />}
+                {networkType !== 'bitcoin' && networkType !== 'ethereum' && (
+                    <MiscDetails {...props} />
+                )}


would be good to create switch

tomasklim · 2025-01-24T17:12:01Z

packages/suite/src/components/wallet/Fees/FeeDetails.tsx

+    const theme = useTheme();
+
+    return (
+        <WrapperWithCheckmark selected={selected}>


This can be feature of the new component added to @trezor/component

coderabbitai · 2025-02-03T11:00:12Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tomasklim requested changes Jan 16, 2025

View reviewed changes

enjojoy force-pushed the feat/priority-fees branch 13 times, most recently from 1976ef5 to 51b93d9 Compare January 17, 2025 14:40

tomasklim reviewed Jan 17, 2025

View reviewed changes

packages/connect/src/api/bitcoin/Fees.ts Show resolved Hide resolved

enjojoy force-pushed the feat/priority-fees branch 3 times, most recently from 8b615ab to a02ee59 Compare January 22, 2025 16:30

tomasklim requested changes Jan 24, 2025

View reviewed changes

enjojoy force-pushed the feat/priority-fees branch from a02ee59 to bef5516 Compare February 3, 2025 11:00

enjojoy force-pushed the feat/priority-fees branch 5 times, most recently from 9062eec to 816379a Compare February 3, 2025 16:00

enjojoy force-pushed the feat/priority-fees branch from 816379a to f169878 Compare February 4, 2025 15:32

feat(suite): fees redesign

92b1582

enjojoy force-pushed the feat/priority-fees branch from f169878 to 5ee6a6e Compare February 11, 2025 10:44

chore(suite): wip

25460db

enjojoy force-pushed the feat/priority-fees branch from 5ee6a6e to 25460db Compare February 11, 2025 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(suite): add priority fee network feature #16342

chore(suite): add priority fee network feature #16342

enjojoy commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

tomasklim Jan 17, 2025

tomasklim Jan 17, 2025

enjojoy Jan 17, 2025

tomasklim Jan 17, 2025

tomasklim Jan 17, 2025

tomasklim Jan 17, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

tomasklim Jan 24, 2025

coderabbitai bot commented Feb 3, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

		{ ...baseLevel, label: 'normal' as const, blocks: -1, ethFeeType: 'legacy' },
		...eip1559Levels,

	defaultMessage: 'Max priority fee per gas',
	defaultMessage: 'Max priority fee',

	defaultMessage: 'Max fee per gas',
	defaultMessage: 'Max fee',

	const shouldUsePriorityFees = network?.features?.includes('eip1559');
	const shouldUsePriorityFees = getNetworkFeatures(symbol).includes("eip1559");

chore(suite): add priority fee network feature #16342

Are you sure you want to change the base?

chore(suite): add priority fee network feature #16342

Conversation

enjojoy commented Jan 14, 2025 • edited Loading

Description

Related Issue

Screenshots:

github-actions bot commented Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot commented Feb 3, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

enjojoy commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)