fix(connect): allow to: null in ethereumSignTransaction for contract deployment

[martykan]

Description

to: null is used in Ethereum transactions that are deploying a new contract.
Previously we only accepted empty strings, which is not ideal.

[coderabbitai]

Walkthrough

This pull request introduces changes to enhance the handling of parameter descriptions and the recipient address in Ethereum transaction components and APIs. The ParamsTable component has been updated to accept an additional descriptions property, which allows for the display of contextual information for parameters. Documentation for Ethereum transaction signing has been revised to include a new entry that clarifies the acceptable values for the to parameter. In the API layer, a condition was added to ensure that the contractAddress is only set when both transaction data exists and the to field is not null. The function signatures for both Ethereum transaction signing functions have been modified to allow the to parameter to be either a string or null, with null values normalized to undefined. Additionally, the type definitions for Ethereum transactions have been updated to reflect this change.

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da460c3 and 847770e.

📒 Files selected for processing (5)

• packages/connect-explorer/src/components/ParamsTable.tsx (1 hunks)
• packages/connect-explorer/src/pages/methods/ethereum/ethereumSignTransaction.mdx (1 hunks)
• packages/connect/src/api/ethereum/api/ethereumSignTransaction.ts (1 hunks)
• packages/connect/src/api/ethereum/ethereumSignTx.ts (5 hunks)
• packages/connect/src/types/api/ethereum/index.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (5)

• packages/connect-explorer/src/pages/methods/ethereum/ethereumSignTransaction.mdx
• packages/connect/src/types/api/ethereum/index.ts
• packages/connect/src/api/ethereum/api/ethereumSignTransaction.ts
• packages/connect-explorer/src/components/ParamsTable.tsx
• packages/connect/src/api/ethereum/ethereumSignTx.ts

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: PR-check / node-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
• GitHub Check: PR-check / node-override init-api-flaky
• GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
• GitHub Check: PR-check / web-override init-api-flaky
• GitHub Check: build-deploy
• GitHub Check: prepare_android_test_app
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: Analyze with CodeQL (javascript)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.