Fix android e2e tests

[marekrjpolak]

Description

Run newly added scheduleUpgradeCheck in DeviceList only when there's at least one preferred transport to which we can upgrade, which should fix Detox tests.

[coderabbitai]

Walkthrough

The changes modify the transport upgrade check logic in the DeviceList class. Previously, an upgrade check was scheduled whenever a transport was present. The update adds a condition to ensure the transport being evaluated is not the most preferred one, identified by transports[0]. Additionally, the exit condition for scheduling upgrade checks now confirms that a transport exists along with verifying it is not the preferred transport. This adjustment ensures upgrade checks are only scheduled when a non-preferred, valid transport is present.

Possibly related PRs

• Feat/upgrade to bridge #16780: Introduces a new method for scheduling upgrade checks and managing timeouts within the DeviceList class, indicating a direct relation in code-level modifications.

Suggested labels

bug

Suggested reviewers

• szymonlesisz
• martykan
• mroz22

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a1177d and 7279291.

📒 Files selected for processing (1)

• packages/connect/src/device/DeviceList.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: build-deploy
• GitHub Check: build
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: prepare_android_test_app
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (3)

packages/connect/src/device/DeviceList.ts (3)

383-386: LGTM! The condition for scheduling upgrade checks is now more precise.

The change ensures that upgrade checks are only scheduled when a non-preferred transport is being used, which aligns with the PR's objective of fixing Android e2e tests by preventing unnecessary upgrade checks.

---

410-410: LGTM! The exit condition is now more robust.

The updated exit condition if (!transport || transport === transports[0]) return; properly handles both cases:

1. No transport available
2. Current transport is already the most preferred one

This prevents unnecessary upgrade attempts and helps stabilize the e2e tests.

---

383-410: Verify the impact on Android e2e tests.

The changes look good and align with the PR's objective of fixing Android e2e tests. Let's verify that these changes resolve the test issues by checking for related test configurations and failures.

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for related Android e2e test configurations and failures
echo "Searching for Android e2e test files..."
fd -e ts -e js --full-path '.*e2e.*android.*' -x cat {}

echo "Searching for Detox test configurations..."
fd -g '*detox*' -t f -x cat {}

Length of output: 278

---

Impact on Android e2e Tests Verified

The search for Android-specific e2e test files and Detox configurations returned no additional configurations, and the changes align with addressing instability related to transport upgrade checks. No related test configurations imply that the adjustments do not interfere with existing Android e2e testing setups.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[PeKne]

Test are passing, approving ✅