Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect): ts config in installing connect test #16869

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

karliatto
Copy link
Member

Description

After adding @solana-program/... dependencies the test for installing connect and compile it with TS was failing, this configuration fixes it and makes it clear it requries target ES2022 and module commonjs.

Copy link

coderabbitai bot commented Feb 6, 2025

Walkthrough

The pull request modifies the test-yarn-install.sh script by updating the TypeScript compilation command. The previous command, which executed yarn tsc ./index.ts with specific type definitions and the --esModuleInterop flag, has been changed to include additional flags: --target ES2022 and --module commonjs. These modifications specify that the TypeScript compiler should target ECMAScript 2022 and utilize the CommonJS module system for the output. There are no changes to the declarations of exported or public entities.

Suggested reviewers

  • Nodonisko
  • mroz22
  • szymonlesisz

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40733ee and be0ebcd.

📒 Files selected for processing (1)
  • packages/connect/e2e/test-yarn-install.sh (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/connect/e2e/test-yarn-install.sh
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: PR-check / node-override init-api-flaky
  • GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
  • GitHub Check: build-deploy
  • GitHub Check: prepare_android_test_app
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@karliatto karliatto added the no-project This label is used to specify that PR doesn't need to be added to a project label Feb 6, 2025
@karliatto karliatto force-pushed the fix/ts-config-in-install-connect-test branch from fd39040 to 40733ee Compare February 6, 2025 12:27
@@ -22,4 +22,5 @@ echo import TrezorConnect from \"@trezor/connect\" >index.ts

# compile with typescript
yarn add [email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I thought that it was necessary typescript@latest but actually with previous [email protected] works as well.

@karliatto karliatto marked this pull request as ready for review February 6, 2025 12:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc4e4c4 and 40733ee.

📒 Files selected for processing (1)
  • packages/connect/e2e/test-yarn-install.sh (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Unit Tests
  • GitHub Check: methods / web
  • GitHub Check: methods / core_in_popup
  • GitHub Check: run_android_e2e_tests

packages/connect/e2e/test-yarn-install.sh Outdated Show resolved Hide resolved
@karliatto karliatto force-pushed the fix/ts-config-in-install-connect-test branch from 40733ee to be0ebcd Compare February 6, 2025 13:47
@karliatto karliatto merged commit e329be8 into develop Feb 6, 2025
58 checks passed
@karliatto karliatto deleted the fix/ts-config-in-install-connect-test branch February 6, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-project This label is used to specify that PR doesn't need to be added to a project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants