Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connect-plugin-stellar): update dep #16876

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Conversation

tomasklim
Copy link
Member

Description

Update trends lib

Related Issue

Resolve

Screenshots:

@tomasklim tomasklim added the no-project This label is used to specify that PR doesn't need to be added to a project label Feb 6, 2025
Copy link

coderabbitai bot commented Feb 6, 2025

Walkthrough

The changes update dependency versions across multiple packages. In several package.json files, the version of @everstake/wallet-sdk was updated from ^1.0.7 to ^1.0.10. Additionally, the version of @solana-program/token-2022 was updated from ^0.3.1 to ^0.3.4 in both the blockchain-link and connect packages. The @metamask/eth-sig-util dependency was upgraded from ^8.0.0 (and from ^7.0.1 in the changelog) to ^8.2.0 in the connect-plugin-ethereum package. Similarly, in the connect-plugin-stellar package and its changelog, @stellar/stellar-sdk was updated from ^12.1.3 to ^13.1.0. Additionally, the json-schema-to-typescript version was updated from ^13.1.2 to ^15.0.4 in the suite-common/message-system package. No changes to package structure or additional configurations were made.

Suggested labels

release

Suggested reviewers

  • martykan
  • szymonlesisz
  • karliatto
  • vdovhanych

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1aa8306 and fac1f85.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (7)
  • packages/blockchain-link-types/package.json (1 hunks)
  • packages/blockchain-link-utils/package.json (1 hunks)
  • packages/blockchain-link/package.json (1 hunks)
  • packages/connect/package.json (1 hunks)
  • packages/suite/package.json (1 hunks)
  • suite-common/message-system/package.json (1 hunks)
  • suite-common/wallet-utils/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (7)
  • packages/blockchain-link-utils/package.json
  • suite-common/message-system/package.json
  • packages/connect/package.json
  • suite-common/wallet-utils/package.json
  • packages/suite/package.json
  • packages/blockchain-link/package.json
  • packages/blockchain-link-types/package.json
⏰ Context from checks skipped due to timeout of 90000ms (17)
  • GitHub Check: build-deploy
  • GitHub Check: build-deploy
  • GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
  • GitHub Check: transport-e2e-test
  • GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: EAS Update
  • GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
  • GitHub Check: build
  • GitHub Check: prepare_android_test_app
  • GitHub Check: test
  • GitHub Check: build-web
  • GitHub Check: build-web
  • GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: Socket Security: Pull Request Alerts

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

socket-security bot commented Feb 6, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

github-actions bot commented Feb 6, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

@tomasklim tomasklim force-pushed the chore/update-trends branch from 027ec60 to 26e1727 Compare February 6, 2025 15:25
@tomasklim
Copy link
Member Author

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@ethersproject/[email protected]
@SocketSecurity ignore npm/@ethersproject/[email protected]
@SocketSecurity ignore npm/[email protected]

Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile tested 🚀

@tomasklim tomasklim force-pushed the chore/update-trends branch from 26e1727 to 1aa8306 Compare February 7, 2025 16:15
@tomasklim
Copy link
Member Author

/rebase

Copy link

github-actions bot commented Feb 7, 2025

@tomasklim tomasklim force-pushed the chore/update-trends branch from 1aa8306 to fac1f85 Compare February 7, 2025 16:49
@tomasklim tomasklim merged commit cf806ff into develop Feb 7, 2025
75 checks passed
@tomasklim tomasklim deleted the chore/update-trends branch February 7, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-project This label is used to specify that PR doesn't need to be added to a project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants