-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(connect): reduce verbosity of logs for better readability of te… #16896
Conversation
WalkthroughThe pull request updates the logging approach within the connect package. In the core index file and the main index file, the logging statements have been modified so that only the message type is logged instead of the entire message object. This change refines the log output without altering the existing method logic, control flow, error handling, or public entity declarations. Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/connect-popup/src/index.tsx (1)
245-245
: LGTM! Consider standardizing logging format across handlers.The change to log only the message type instead of the entire data object improves log readability. This aligns well with the PR objective of reducing log verbosity.
For consistency, consider applying similar logging format in other message handlers:
// In handleMessageInCoreMode (around line 321): - log.debug('handling method in popup', method.name); + log.debug('handleMessage', method.name); // In handleContentScriptLoaded (around line 383): - log.debug('content-script loaded', data.payload); + log.debug('handleMessage', 'content-script-loaded');
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/connect-popup/src/index.tsx
(1 hunks)packages/connect-web/src/impl/core-in-iframe.ts
(1 hunks)packages/connect/src/core/index.ts
(1 hunks)packages/connect/src/index.ts
(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/connect/src/index.ts
- packages/connect-web/src/impl/core-in-iframe.ts
- packages/connect/src/core/index.ts
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: webextension-examples / webextension
- GitHub Check: transport / web
- GitHub Check: permissions / web
- GitHub Check: passphrase / webextension
- GitHub Check: passphrase / web
- GitHub Check: passphrase / core_in_popup
- GitHub Check: methods / core_in_popup
- GitHub Check: methods / web
- GitHub Check: browser-support / web
- GitHub Check: popup-pages / web
- GitHub Check: popup-close / webextension
- GitHub Check: popup-close / web
- GitHub Check: popup-close / core_in_popup
- GitHub Check: run_android_e2e_tests
- GitHub Check: Type Checking
- GitHub Check: Unit Tests
1b5b3d5
to
561c700
Compare
…rminal output
that should help us navigate and read the logs