Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): remove word trend from SOL graph banner #16900

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Nodonisko
Copy link
Contributor

Description

Related Issue

Resolve #16826

Screenshots:

@Nodonisko Nodonisko requested a review from a team as a code owner February 10, 2025 10:35
Copy link

coderabbitai bot commented Feb 10, 2025

Walkthrough

The changes update the translation string for the Solana network in the internationalization file located in the suite-native/intl/src/en.ts module. Specifically, the text for the sol key within moduleHome has been revised by removing the word "trend" from the warning message, changing it from "Solana is not included in the graph trend." to "Solana is not included in the graph." This update directly reflects the requirement to simplify and clarify the alert message concerning the inclusion of Solana in the graph.

Assessment against linked issues

Objective Addressed Explanation
Remove "trend" from Solana warning [#16826]

Suggested labels

mobile

Suggested reviewers

  • matejkriz

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66732f7 and 380f817.

📒 Files selected for processing (1)
  • suite-native/intl/src/en.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: prepare_android_test_app
  • GitHub Check: EAS Update
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: Setup and Cache Dependencies
🔇 Additional comments (1)
suite-native/intl/src/en.ts (1)

41-41: LGTM! The message is now clearer and more concise.

The translation string has been simplified by removing the word "trend", which makes the message more straightforward and easier to understand.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Nodonisko
Copy link
Contributor Author

/rebase

Copy link

Copy link

github-actions bot commented Feb 10, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

@trezor-ci trezor-ci force-pushed the feat/remove-sol-graph-banner branch from 66732f7 to e30e880 Compare February 10, 2025 10:39
@Nodonisko Nodonisko force-pushed the feat/remove-sol-graph-banner branch from e30e880 to 380f817 Compare February 10, 2025 11:02
@Nodonisko Nodonisko changed the title feat(mobile): remove SOL graph banner feat(mobile): remove word trend from SOL graph banner Feb 10, 2025
@Nodonisko
Copy link
Contributor Author

/rebase

@Nodonisko Nodonisko enabled auto-merge (squash) February 11, 2025 08:46
Copy link

@trezor-ci trezor-ci force-pushed the feat/remove-sol-graph-banner branch from 380f817 to a4db009 Compare February 11, 2025 08:47
@Nodonisko Nodonisko merged commit faf3e06 into develop Feb 11, 2025
16 checks passed
@Nodonisko Nodonisko deleted the feat/remove-sol-graph-banner branch February 11, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "trend" from Solana warning
2 participants